From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Correct byte compiler error/warning positions. The solution! Date: Sat, 27 Nov 2021 12:07:10 +0200 Message-ID: <8335nh29pt.fsf@gnu.org> References: <83pmqm16vz.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30824"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 27 11:07:43 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mqucR-0007pq-8f for ged-emacs-devel@m.gmane-mx.org; Sat, 27 Nov 2021 11:07:43 +0100 Original-Received: from localhost ([::1]:42346 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mqucQ-0001WK-4C for ged-emacs-devel@m.gmane-mx.org; Sat, 27 Nov 2021 05:07:42 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46430) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqubo-0000ps-Qt for emacs-devel@gnu.org; Sat, 27 Nov 2021 05:07:06 -0500 Original-Received: from [2001:470:142:3::e] (port=53706 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqubo-0004Iy-91; Sat, 27 Nov 2021 05:07:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=sSbe8kgAe5bUO7yox4zi6SikQ2Mz5kLKVIh3dc7EQHM=; b=mH9IoHPF7vNH 7sFewfp+G+YaR1QP5dDU+imr4ee0mRWeO5nNHh0CHTIVpHmCe9XWZ9+Q/dIXgtd9p/lMptCSenMU2 I0yMYtTVzQ1UF8f79jJ0d99J58TfZSmt5w6gozbZDJk+remq1qKVfigicq/M5EpJQCrgqkmVTd89q 6AmXkdSuJioslQsyKiUBRd5NPw2jB94JLxcbqGgS5/QKyRNLSSBNCuYtbuZ2XepgOUZPyhgev5wi7 Z3HmBrS70bAzLOMQcDUDAC8bxCp0fTbEaw/M8zh2EaMJDvaTOkrGDODOWrEzonQUWMgFD3r+fbLkU T0p21ZXaLQNPBbcAMOlqBQ==; Original-Received: from [87.69.77.57] (port=2198 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqubn-00023s-L4; Sat, 27 Nov 2021 05:07:04 -0500 In-Reply-To: (message from Alan Mackenzie on Sat, 27 Nov 2021 09:31:05 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:280312 Archived-At: > Date: Sat, 27 Nov 2021 09:31:05 +0000 > Cc: emacs-devel@gnu.org > From: Alan Mackenzie > > Hello, Eli. > > On Sat, Nov 27, 2021 at 07:53:36 +0200, Eli Zaretskii wrote: > > > Date: Fri, 26 Nov 2021 19:56:21 +0000 > > > From: Alan Mackenzie > > > > A _LOT_ of these comparisons were for NILP, which is just #defined as EQ > > > (arg, Qnil). However if NILP were to be defined directly as arg == > > > Qnil, it would bypass the overhead in EQ. > > > How can you use == when the operands could be structures? > > I meant that NILP will be implemented as a binary comparison against > zero, omitting the awkward test for symbols_with_position_enabled. Please don't write code that assumes Qnil is zero. (Or maybe I still misunderstand what exactly you mean by the above.)