unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: Re: master 6ed1994d27: Prevent crashes from illegal locale coding systems
Date: Tue, 15 Feb 2022 16:07:26 +0200	[thread overview]
Message-ID: <8335kk440x.fsf@gnu.org> (raw)
In-Reply-To: <87czjow7x1.fsf@yahoo.com> (message from Po Lu on Tue, 15 Feb 2022 21:55:54 +0800)

> From: Po Lu <luangruo@yahoo.com>
> Cc: emacs-devel@gnu.org
> Date: Tue, 15 Feb 2022 21:55:54 +0800
> 
> > But this means we cannot call the decoding stuff there at all, because
> > some coding-systems call into Lisp, and Lisp can signal an error.  So
> > we probably should take the raw bytes in that place, record them in
> > the event queue, and then decode it later, when it's safe.
> 
> What safe place would you find appropriate for the job?

Where we read input in keyboard.c, for example.  Basically, any time
we are in the "normal" context of the main thread and in the Emacs
command loop.

> And I'm not sure if we have a mechanism in place to record the raw
> bytes that way, so one will have to be devised.

The event queue has members that are Lisp objects; can't you use them
to record unibyte strings?



  reply	other threads:[~2022-02-15 14:07 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-13 13:00 master 6ed1994d27: Prevent crashes from illegal locale coding systems Eli Zaretskii
2022-02-13 13:16 ` Po Lu
2022-02-13 13:45   ` Eli Zaretskii
2022-02-14  0:51     ` Po Lu
2022-02-14  3:32       ` Eli Zaretskii
2022-02-14  4:46         ` Po Lu
2022-02-14 14:07           ` Eli Zaretskii
     [not found]             ` <87iltheyeu.fsf@yahoo.com>
     [not found]               ` <83wnhwol2o.fsf@gnu.org>
     [not found]                 ` <87tud0ybhj.fsf@yahoo.com>
     [not found]                   ` <837d9w450e.fsf@gnu.org>
2022-02-15 13:55                     ` Po Lu
2022-02-15 14:07                       ` Eli Zaretskii [this message]
2022-02-16  0:49                         ` Po Lu
2022-02-16  2:38                           ` Po Lu
2022-02-16  5:12                             ` Po Lu
2022-02-16 12:22                               ` Eli Zaretskii
2022-02-16 12:33                                 ` Po Lu
2022-02-16 12:38                                   ` Eli Zaretskii
2022-02-16 13:05                                     ` Po Lu
2022-02-16 13:33                                       ` Eli Zaretskii
2022-02-16 13:40                                         ` Po Lu
2022-02-16 14:05                                           ` Eli Zaretskii
2022-02-17  0:45                                             ` Po Lu
2022-02-17  6:31                                               ` Eli Zaretskii
2022-02-17  6:51                                                 ` Po Lu
2022-02-17  7:23                                                   ` Eli Zaretskii
2022-02-17  7:44                                                     ` Po Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8335kk440x.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).