unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Joost <joostkremers@fastmail.fm>
Cc: emacs-devel@gnu.org
Subject: Re: csv-mode: header does not align when line numbers are displayed
Date: Fri, 29 Apr 2022 13:40:20 +0300	[thread overview]
Message-ID: <8335hwb2az.fsf@gnu.org> (raw)
In-Reply-To: <64bbe68b-f2b9-4cb5-93b8-07e5720e74fa@www.fastmail.com> (message from Joost on Fri, 29 Apr 2022 09:47:08 +0200)

> Date: Fri, 29 Apr 2022 09:47:08 +0200
> From: Joost <joostkremers@fastmail.fm>
> 
> Not sure if this should be reported as a bug or not; let me know if it should.

The bug tracker is not just for bugs, it is also for features.  So
yes, please post such suggestions via "M-x report-emacs-bug".

> `csv-mode` has the option to display a header line so you can make column names permanently visible, which is a very nice option. However, when `display-line-numbers-mode` is active, the column names do not line up with the actual columns, because the header line does not take into account the space taken up by the line numbers.
> 
> The following patch seems to be a quick fix:

Thanks.

> Though it doesn't automatically adjust the header line when `display-line-numbers-mode` is toggled or if `display-line-number-width` changes, so it's probably not the ideal solution.

Indeed.  I think tabulated-list.el shows how to cause the adjustment
when the variable is toggled.  Can you use those ideas to submit a
better solution?




  reply	other threads:[~2022-04-29 10:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-29  7:47 csv-mode: header does not align when line numbers are displayed Joost
2022-04-29 10:40 ` Eli Zaretskii [this message]
2022-05-12 15:40   ` Joost Kremers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8335hwb2az.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=joostkremers@fastmail.fm \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).