From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: bug#55719: [PATCH] bindat strz fixes Date: Tue, 31 May 2022 14:08:04 +0300 Message-ID: <8335gqj6y3.fsf@gnu.org> References: <77e643ea-9e19-f4e3-c109-6233eb84d56b@rhansen.org> <6b1670d3-ae69-7f95-0e7d-d7cee0763c4a@rhansen.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30158"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, 55719@debbugs.gnu.org To: Richard Hansen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue May 31 13:33:04 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nw07T-0007ei-8j for ged-emacs-devel@m.gmane-mx.org; Tue, 31 May 2022 13:33:03 +0200 Original-Received: from localhost ([::1]:44506 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nw07Q-0006VW-W6 for ged-emacs-devel@m.gmane-mx.org; Tue, 31 May 2022 07:33:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51004) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nvzjI-00047C-5H for emacs-devel@gnu.org; Tue, 31 May 2022 07:08:04 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:33864) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nvzjF-0008SW-RG; Tue, 31 May 2022 07:08:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=lRuMUV2rmlRyl7ykHtfSF/SdKD/2csLz8JXyuIFGcyI=; b=RmWoDxY9CoWr E90Ii2oyg0SmbVkbe+kOcO7SzKPyP6uVhmjtQCBnvdHz7af+xVbPR15O52w6kQYBjuI6Sh6P3NWQV jJco3TAfMre1e3gmo7tgU90A1dMhJOBK2hXdPf58tjVY6KFFwimdBs+FN6wh8ubr2ep9/MKMTEV0M sIZKvw2l5xC2fCbdXe2ICrlYwr/RQROylrzke5hgcdbXSBm8yIDayqaCfHS9s4bZ/San1SFPb+ftj o6GNMhgg5/nVA0nFbgtt33Ilve6UaVofNdMgJcOEczZo0ahGxD0TcxnwUwmA2heO9EPhOry5wAAH1 /Ar/dp+lxhycBkR75RTp7A==; Original-Received: from [87.69.77.57] (port=4688 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nvzjE-000816-QA; Tue, 31 May 2022 07:08:01 -0400 In-Reply-To: <6b1670d3-ae69-7f95-0e7d-d7cee0763c4a@rhansen.org> (message from Richard Hansen on Mon, 30 May 2022 12:53:31 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:290397 Archived-At: > Cc: 55719@debbugs.gnu.org > Date: Mon, 30 May 2022 12:53:31 -0400 > From: Richard Hansen > > The attached series of patches should fix bug #55719 (https://debbugs.gnu.org/cgi/bugreport.cgi?bug=55719). Aren't those all due to the issue of including the terminating null byte in a packed string? And if so, I wonder whether indeed the null byte should be included, since that means you cannot handle strings that include null bytes as part of the payload, not as terminators. Can you tell why you are convinced the null byte should be considered as part of the string? Thanks.