From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: undo-auto--undoable-change infloop Date: Wed, 27 Jul 2022 20:34:48 +0300 Message-ID: <8335embgsn.fsf@gnu.org> References: <87o7xc1qbh.fsf@web.de> <831qu8dqrx.fsf@gnu.org> <87bktbciup.fsf@web.de> <83o7xaby5a.fsf@gnu.org> <8735emcwoa.fsf@web.de> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11399"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Michael Heerdegen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jul 27 19:57:35 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oGlHr-0002pv-3e for ged-emacs-devel@m.gmane-mx.org; Wed, 27 Jul 2022 19:57:35 +0200 Original-Received: from localhost ([::1]:33784 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oGlHp-0008LV-SZ for ged-emacs-devel@m.gmane-mx.org; Wed, 27 Jul 2022 13:57:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36248) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGkvh-0006hf-5v for emacs-devel@gnu.org; Wed, 27 Jul 2022 13:34:42 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34748) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGkvg-00087f-SL; Wed, 27 Jul 2022 13:34:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=TTZqYwkvvUiwtS5rnsCnCZF/o3CFudCn1LHI2qErEPg=; b=SYmxEVV12Tln fQZGKcp7u/Y2dhHhp0h1RLTfM5dM6fMH+FtdmDcwpfSMJpMY7WVKYzg+db9IklRNUyo36pHJEBaLA tGwmCoHrVioRZNXydBblHBezzw0YJ8zUwb4JkjheonD7RsHERePgWejd8BOx4bwOZhUegohMtTOqx xnqlrkXYsn7IOISS3d8Wi6JfKqmQQopLdQ8H2n1Bc3GXlyns/OiP84UQ+aHcdl/HhswC596/jh188 A0PHmFqTKyS2q7K3kUqObj6Rbamoiwka/Mi5BZ4SRDGjtSPToQqmxzN9oCt5kIsBmvztdwauXVJh3 Yj8sXyATKEmO6JC7TiUkhg==; Original-Received: from [87.69.77.57] (port=1423 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGkvg-0003gk-BP; Wed, 27 Jul 2022 13:34:40 -0400 In-Reply-To: <8735emcwoa.fsf@web.de> (message from Michael Heerdegen on Wed, 27 Jul 2022 19:06:29 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:292749 Archived-At: > From: Michael Heerdegen > Date: Wed, 27 Jul 2022 19:06:29 +0200 > > Eli Zaretskii writes: > > > > A CPU profiler report looks like this, with stuff less than 3% removed: > > > > > > 24220 41% - timer-event-handler > > > 21654 37% - timer-activate > > > 19231 33% - timer--activate > > > 17774 30% timer--time-less-p > > > 19949 34% - ... > > > 19949 34% Automatic GC > > > 14040 24% + command-execute ;; actual command execution time > > > [...] [...] > > > > > > This is a very strange result, not saying anything to me. > > > > Why does it seem strange to you? > > That there is no Lisp function there besides the timer stuff. Undo > stuff like amalgamating is done in Lisp, so such function(s) should > appear there if they do work or initiate it. And 30% time spent in > `timer--time-less-p' doesn't look sane. It's 30% for timer--time-less-p _and_its_callees_, so you should look deeper. The 34% figure for GC also doesn't look good, btw.