From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 40c0124816: Minor improvements to precision scroll interpolation Date: Sat, 30 Jul 2022 08:58:40 +0300 Message-ID: <8335ej6t0v.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10776"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jul 30 07:59:38 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oHfVh-0002h2-1l for ged-emacs-devel@m.gmane-mx.org; Sat, 30 Jul 2022 07:59:37 +0200 Original-Received: from localhost ([::1]:44120 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oHfVf-00078s-Pq for ged-emacs-devel@m.gmane-mx.org; Sat, 30 Jul 2022 01:59:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56292) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oHfUZ-0006Rf-9y for emacs-devel@gnu.org; Sat, 30 Jul 2022 01:58:27 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58338) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oHfUZ-0000pt-1C; Sat, 30 Jul 2022 01:58:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=Subject:To:From:Date:mime-version:in-reply-to: references; bh=d1DNUR3aezAXmrC3ZeKG4jieBfow912/ycmej7uyiW8=; b=pYGkbdvLWkt4/O rlQZUbeGH//dv5EIxmTEWlEFyUNO8rGAG004fynfmtdnSzWd1GERbE+azvP6czKjDYJL3MZ2R00pd kkNybyhqxh0jd3atPkl8M6OU1UWg0aQH99x3lftLN9Yt5ucuZ1Jdbd68hghxlrZgzct1q97JEqJ9L cXZB5Sq0vOL924ZWwLRwzssy9syUUWf5P7KkWbG+TB9rzE2FqxPY84OGHk5d2kVJsb4XksKGQ++MA vF6JqQADzfss7FO08jpVo3NcH4CTlOxakoOpnHS5LEjOpvK+RTaIr9w6yCdzqxeXMaDmX4EBACJeI Gl48iUacfXXoeyMqMmwg==; Original-Received: from [87.69.77.57] (port=1308 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oHfUY-0007RT-D7; Sat, 30 Jul 2022 01:58:26 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:292850 Archived-At: > --- a/lisp/pixel-scroll.el > +++ b/lisp/pixel-scroll.el > @@ -759,6 +759,9 @@ It is a vector of the form [ VELOCITY TIME SIGN ]." > (interactive "e") > (when pixel-scroll-precision-use-momentum > (let ((window (mwheel-event-window event)) > + ;; The animations are smoother if the GC threshold is > + ;; reduced for the duration of the animation. > + (gc-cons-threshold (* gc-cons-threshold 3)) > (state nil)) I don't think it is safe to multiply gc-cons-threshold without some kind of limitation from above: the user or some Lisp program could have increased the threshold already to a large value.