From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Turing on tree-sitter (was: Call for volunteers: add tree-sitter support to major modes) Date: Mon, 10 Oct 2022 11:18:06 +0300 Message-ID: <8335bwhz29.fsf@gnu.org> References: <83czb1jrm3.fsf@gnu.org> <87v8ot2nfi.fsf@posteo.net> <837d19jfia.fsf@gnu.org> <83edvgi3mx.fsf@gnu.org> <87r0zg5g76.fsf@thornhill.no> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12633"; mail-complaints-to="usenet@ciao.gmane.io" Cc: philipk@posteo.net, emacs-devel@gnu.org, casouri@gmail.com To: Theodor Thornhill Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Oct 10 10:22:57 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oho3s-00033l-TK for ged-emacs-devel@m.gmane-mx.org; Mon, 10 Oct 2022 10:22:57 +0200 Original-Received: from localhost ([::1]:55428 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oho3r-0007gZ-Kb for ged-emacs-devel@m.gmane-mx.org; Mon, 10 Oct 2022 04:22:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41818) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohnz7-0004wo-OT for emacs-devel@gnu.org; Mon, 10 Oct 2022 04:18:01 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36800) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohnz6-0000L9-FI; Mon, 10 Oct 2022 04:18:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=jb5SC++Sm19NAv2E8zfRjKHyfrDj6CxT/ZY746Y0y38=; b=k5BGW7i8kLPO q+AL+b13CiMnBDtqUpqwUx8Mdi5sYLZBLvciICfTMArgyciVb38q0OGRc5GdzwzND7RdSUbMLeJDh mq93Kp/IHtS3azUTAnt2aUiOtmMbxw5f2TlxlOitlzPqsfB0qKfWjG8hRzIkqCqgElHeb3km1G+fd BFUvO1M5LmeHKZ10E3stnkFbAIsceG0RzeoLnqLX9XXHRN5ITKCCjk/afNBDszG4AHU7mzvM6+tuF KD1aqd1RyBYl9Q7+LtDIEDYK4BbGXDdRE0dCkrQIw0BOkMBeemB/j4KoL2wS2ExfI1PCCIcloTL2s o2vSaxrIYgGE1YWvlmQHZg==; Original-Received: from [87.69.77.57] (port=1828 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohnz5-0003BH-Px; Mon, 10 Oct 2022 04:18:00 -0400 In-Reply-To: <87r0zg5g76.fsf@thornhill.no> (message from Theodor Thornhill on Mon, 10 Oct 2022 08:46:21 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297333 Archived-At: > From: Theodor Thornhill > Cc: emacs-devel@gnu.org, casouri@gmail.com > Date: Mon, 10 Oct 2022 08:46:21 +0200 > > > Since tree-sitter support is per-language, I do think it makes sense > > for each mode to have its tree-sitter support turned on separately. > > But we could also have a global "turn on tree-sitter support in every > > mode that has it" option, which will turn this on for those modes > > which can be supported by tree-sitter, if the appropriate > > language-support library is installed. > > > > Comments? > > +1 for this, but also keep the per-modes customs. Then we can eat the > cake and have it too. > > Such a mechanism can be made later, I think? Yes. But ideally before Emacs 29 starts the release cycle, since the global variable should be heeded by all the modes. It should also be in the manual.