From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: rms@gnu.org, joaotavora@gmail.com, emacs-devel@gnu.org,
stephen_leake@stephe-leake.org
Subject: Re: master 31945b6c3f: * lisp/progmodes/eglot.el (eglot): Ensure managed-major-mode is a list
Date: Sat, 29 Oct 2022 08:56:04 +0300 [thread overview]
Message-ID: <8335b7jhqj.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkmmma9-V+E5ADNg2T7uy+W0JpU+txGiKfqeJN9DCFqoWJw@mail.gmail.com> (message from Stefan Kangas on Fri, 28 Oct 2022 12:45:58 -0700)
> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Fri, 28 Oct 2022 12:45:58 -0700
> Cc: joaotavora@gmail.com, emacs-devel@gnu.org, stephen_leake@stephe-leake.org
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > Our project-wide preference is the other way around: we ask
> > contributors not to make any whitespace changes except where they
> > actually change code, or nearby.
>
> AFAIK, the reasons not to do cosmetic whitespace changes is that they
> make history harder to read, and merging harder.
They also make patches harder to review, sometimes much harder.
> However, any reasonably modern VCS will have an option to ignore
> whitespace changes (Git does). And a lot of code in Emacs change very
> infrequently. At the same time, whitespace changes can in some cases
> make the structure of code clearer, and thereby easier to understand.
>
> I therefore think we could relax our project-wide policy along the lines
> of what Richard and João suggest.
Not as long as the "diff" operation of the VCS treats whitespace as
significant by default. Presumably, they do this for a reason, and
therefore patches we get to review do not ignore whitespace.
next prev parent reply other threads:[~2022-10-29 5:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <166668943749.31970.9379739764487638921@vcs2.savannah.gnu.org>
[not found] ` <20221025091717.DD9A3C0E4BF@vcs2.savannah.gnu.org>
2022-10-25 9:29 ` master 31945b6c3f: * lisp/progmodes/eglot.el (eglot): Ensure managed-major-mode is a list João Távora
2022-10-25 9:35 ` João Távora
2022-10-27 20:13 ` Richard Stallman
2022-10-28 5:42 ` Eli Zaretskii
2022-10-28 8:32 ` João Távora
2022-10-28 11:30 ` Eli Zaretskii
2022-10-28 19:45 ` Stefan Kangas
2022-10-29 5:56 ` Eli Zaretskii [this message]
2022-10-29 6:52 ` Stefan Kangas
2022-10-29 7:24 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8335b7jhqj.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=joaotavora@gmail.com \
--cc=rms@gnu.org \
--cc=stefankangas@gmail.com \
--cc=stephen_leake@stephe-leake.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).