From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 2c8b09b06e7: Fix crash on Windows 9X Date: Wed, 07 Dec 2022 14:42:54 +0200 Message-ID: <83359r5qr5.fsf@gnu.org> References: <167029029523.21453.12133435240921985505@vcs2.savannah.gnu.org> <20221206013135.E2E2DC004BE@vcs2.savannah.gnu.org> <87fsdtnn8x.fsf@yahoo.com> <83r0xc7mf8.fsf@gnu.org> <87v8mon18x.fsf@yahoo.com> <83h6y87gj5.fsf@gnu.org> <87fsdsm3mp.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22665"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 07 13:43:50 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p2tm9-0005jL-Pe for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Dec 2022 13:43:49 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p2tlY-0004A8-Pe; Wed, 07 Dec 2022 07:43:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2tlW-00049l-9V for emacs-devel@gnu.org; Wed, 07 Dec 2022 07:43:10 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2tlV-0000nI-99; Wed, 07 Dec 2022 07:43:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=fMGNugj1SN7WUHBQOrahpUuhoPuisVK4gt248hodUgc=; b=K1S12OnH+2Aj 6a0GK5+7Yh8cnWnpADjKYL+7fVUIvFas1KvxuKqkUMA8gmOKfiOOTQlPPTetUFSEShQm3nrwo+AfF ru5tMed2fFfwPyRRCzrr0QR+QIGCb5hulKM2QGMLKtgI8W37lB471/78w4c882lheDqRbUOSkU7uV sTgsJPMB8ohiCSCdg3uW4yRV4c1I2+WHqExVJ2A22xw0WwKVXDLh+kiXqhuJUAXqgONsbZ7CVFnuU LA6E0mpkgt6fbz7+sa0s8xr0dDUp+fXHoeNI511Isdn+rHi1Xg9HoqCxgg048bdbb5gkyf3m+9xrB DHpWkLXICEu71NJAmHw+3w==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2tlU-0003Bv-KA; Wed, 07 Dec 2022 07:43:09 -0500 In-Reply-To: <87fsdsm3mp.fsf@yahoo.com> (message from Po Lu on Wed, 07 Dec 2022 08:58:06 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301010 Archived-At: > From: Po Lu > Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org > Date: Wed, 07 Dec 2022 08:58:06 +0800 > > Eli Zaretskii writes: > > > It might, so I'd prefer not to risk such duplicate calls. It should be easy > > to make sure it is called only once when dumping for unexec, and only once > > in the pdumper build (both when dumping and when not dumping). > > Something like this? Without the "if (!initialized)" part, since in the pdumper build we want it invoked both when dumping and when starting after dumping.