From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Changes OK for Emacs 29? Date: Fri, 20 Jan 2023 15:28:10 +0200 Message-ID: <833585nxn9.fsf@gnu.org> References: <87cz797cyu.fsf.ref@yahoo.com> <87cz797cyu.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37315"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jan 20 14:28:49 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pIrRp-0009bj-A5 for ged-emacs-devel@m.gmane-mx.org; Fri, 20 Jan 2023 14:28:49 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pIrRJ-0004PW-4w; Fri, 20 Jan 2023 08:28:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIrRD-0004P8-9s for emacs-devel@gnu.org; Fri, 20 Jan 2023 08:28:11 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIrRC-0003mu-Sh; Fri, 20 Jan 2023 08:28:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Yn5MFyGF+z9I/5Yze4K9nIRFIj4XbePsQZO+o9C1ArE=; b=Y+0TVTJGijzx ULwWcUSG3iMW8+HRJBgXChyJeQwTRZLoN9Gujx4a+hH2C5yN4tLynRv4H4g2E7b6Nf2G2eXLNAmL6 /faHxTGmAOhvLv07g0UP3NmmuDFhwvDIJ3419/RJ9oFYK5VfN3l6SkbWyRVflXF8gOMjoQQBR6oD9 JhRsTCKpepFQ53SI+9D0SOKoDomA602BB9lqzB3jJTfEfIU5YN88LCmd09nFPPNbNfygaenY4y/3Z cjqhH8isny3kL3SbNwqdZyX9bFWgk9rZObZgUF/k/TJ1d0niRz2LfT/oD5OSgZ2NMj6wRohUc4NeU vpcLhExWC5kIxRGy5vuljw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIrRB-0007SR-FV; Fri, 20 Jan 2023 08:28:10 -0500 In-Reply-To: <87cz797cyu.fsf@yahoo.com> (message from Po Lu on Fri, 20 Jan 2023 17:49:13 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302575 Archived-At: > From: Po Lu > Date: Fri, 20 Jan 2023 17:49:13 +0800 > > Users report that the following changes to two functions are needed for > the Delete key to delete forward correctly on Haiku: > > (defun display-symbol-keys-p (&optional display) > "Return non-nil if DISPLAY supports symbol names as keys. > This means that, for example, DISPLAY can differentiate between > the keybinding RET and [return]." > (let ((frame-type (framep-on-display display))) > (or (memq frame-type '(x w32 ns pc pgtk haiku)) > ;; MS-DOS and MS-Windows terminals have built-in support for > ;; function (symbol) keys > (memq system-type '(ms-dos windows-nt))))) > > (defun normal-erase-is-backspace-setup-frame (&optional frame) > "Set up `normal-erase-is-backspace-mode' on FRAME, if necessary." > (unless frame (setq frame (selected-frame))) > (with-selected-frame frame > (unless (terminal-parameter nil 'normal-erase-is-backspace) > (normal-erase-is-backspace-mode > (if (if (eq normal-erase-is-backspace 'maybe) > (and (not noninteractive) > (or (memq system-type '(ms-dos windows-nt)) > (memq window-system '(w32 ns pgtk haiku)) > (and (eq window-system 'x) > (fboundp 'x-backspace-delete-keys-p) > (x-backspace-delete-keys-p)) > ;; If the terminal Emacs is running on has erase char > ;; set to ^H, use the Backspace key for deleting > ;; backward, and the Delete key for deleting forward. > (and (null window-system) > (eq tty-erase-char ?\^H)))) > normal-erase-is-backspace) > 1 0))))) > > Are they ok for Emacs 29? I don't know. Please describe the problem, please show the changes (as diffs, for example), and please explain how these changes fix the problems.