From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Missing features in c-ts-mode Date: Thu, 16 Feb 2023 09:04:33 +0200 Message-ID: <8335769jlq.fsf@gnu.org> References: <83wn4iajyy.fsf@gnu.org> <87fsb67pfj.fsf@thornhill.no> <83lekyagwy.fsf@gnu.org> <87a61e7n5j.fsf@thornhill.no> <838rgyae6z.fsf@gnu.org> <87y1oy65nq.fsf@thornhill.no> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25942"; mail-complaints-to="usenet@ciao.gmane.io" Cc: casouri@gmail.com, emacs-devel@gnu.org To: Theodor Thornhill Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Feb 16 08:05:48 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pSYKx-0006Xc-Qa for ged-emacs-devel@m.gmane-mx.org; Thu, 16 Feb 2023 08:05:48 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pSYKA-0002lx-SS; Thu, 16 Feb 2023 02:04:58 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSYK3-0002hh-E0 for emacs-devel@gnu.org; Thu, 16 Feb 2023 02:04:51 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSYK2-0000wB-RL; Thu, 16 Feb 2023 02:04:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=tSLzI2zHjJ//0ZGuAyYs6DMQ0luT5i8x8XC0K8NHd9U=; b=SKTqrMdWYEFG S5sqKHtwlcIog2krcexvKTbZxaaU5pXBW1gzMUW/oSjEOp1dyix2xTPKk6HTXAx32qaiQg/+5txzD xO2nWkFIsDA2OtPpgYApM7zeNbGZIQ05DaQlA7BXLyPdkKiyj9X1kzWcRhiXW1xJ7KnwAw3Yrx2Mw RboSJFvqujF+U/wPZKzN5aRRkJs/kYf1btGJIh+cCnw7TKokXcKPzkdJIS4RM7GvOsLXr/x8aiboJ GaTX7SR7oBQNvecbEqJLjQA1aGnQn/dCJT8GTN0BItlmztCgYl/LGw0gugDCm1NXBQX8efyL2vi6m kw8BI4hUTlo6tb4KH6n9kw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSYK2-0000gQ-5a; Thu, 16 Feb 2023 02:04:50 -0500 In-Reply-To: <87y1oy65nq.fsf@thornhill.no> (message from Theodor Thornhill on Wed, 15 Feb 2023 21:21:45 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303364 Archived-At: > From: Theodor Thornhill > Cc: casouri@gmail.com, emacs-devel@gnu.org > Date: Wed, 15 Feb 2023 21:21:45 +0100 > > Eli Zaretskii writes: > > > Visit dispnew.c, turn on c-ts-mode, then go to line 174. Type M-a and > > watch in disbelief where it goes. Same surprise if you type M-e. > > Conclusion: preprocessor directives seem to drive this feature crazy. > > > > Hmm, I cannot find any preproc directives there, but I think I > understand what you mean anyway. The directives are "#ifdef GLYPH_DEBUG" on line 129 and the matching #endif on line 234. All that portion of dispnew.c is under that cpp conditional. > > static void > > adjust_glyph_matrix (struct window *w, struct glyph_matrix *matrix, int x, int y, struct dim dim) > > { > > int i; > > int new_rows; > > bool marginal_areas_changed_p = 0; > > bool tab_line_changed_p = 0; <<<<<<<<<<<<<<<<<<<< > > bool tab_line_p = 0; > > > > Position point in the middle of the line and press M-a -- point goes > > to the first non-blank character of the line: good. Now type M-a > > again -- point goes to the first non-blank character of the _previous_ > > line: why? > > Likely because that is the beginning of the "first" previous node > covered by the regexp. Is that unexpected? It was unexpected to some extent. But I see that other beginning-of-SOMETHING commands to the same, so perhaps it's just me. Let's forget about this part, I probably need to adjust my expectations. > > Position point anywhere inside that line and press M-a -- point goes > > to the "if" that encloses this block: why? Moreover, if you go to the > > first line _after_ the braces, the one which begins with "matrix->", > > and press M-a, point still goes to that "if": why? > > > > C-M-f also appears broken: I cannot get it to move from an opening > > brace to the matching closing brace -- instead, it goes to the closing > > parenthesis of some inner expression. For example, try C-M-f here: > > > > else > > { > > /* If MATRIX->pool is null, MATRIX is responsible for managing > > its own memory. It is a window matrix for window-based redisplay. > > Allocate glyph memory from the heap. */ > > if (dim.width > matrix->matrix_w > > || new_rows > > || tab_line_changed_p > > || header_line_changed_p > > || marginal_areas_changed_p) > > { > > struct glyph_row *row = matrix->rows; > > > > Yeah, this is the same bug as in a different bug report, bug#61374. I > didn't get to it yet, apologies! No need to be sorry: this is the master branch, so everything there takes a back seat for now, and emacs-29 is the most important. > Hehe yeah. Thanks! I'll check if just tweaking the regexps is enough, > but likely we need something more in the code dealing with this > too. Thanks for the detailed report though, now I have some clear > expectations to devise tests from. Thanks.