From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: file-equal-p Date: Thu, 16 Feb 2023 13:52:23 +0200 Message-ID: <83357596a0.fsf@gnu.org> References: <87a61es8fh.fsf.ref@yahoo.com> <87a61es8fh.fsf@yahoo.com> <83fsb681me.fsf@gnu.org> <87pmaaq9ua.fsf@yahoo.com> <838rgy7ztf.fsf@gnu.org> <874jrmq6bw.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40694"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Feb 16 12:52:56 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pScop-000ARh-Qg for ged-emacs-devel@m.gmane-mx.org; Thu, 16 Feb 2023 12:52:56 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pScoR-0003eY-9W; Thu, 16 Feb 2023 06:52:31 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pScoP-0003eF-ND for emacs-devel@gnu.org; Thu, 16 Feb 2023 06:52:29 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pScoP-0006Tm-5k; Thu, 16 Feb 2023 06:52:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=W6+hjzCROI2RIMpu85+5v+ny8niDLI0CSp1JYB8fi+I=; b=rj7XIKAu8FrT NRzjFfRqpVOWdps6ksltNAcjzijfNDFUev7qitqHUXJx42O2DMSOyfFh6e6cqQqRF7HbdG0GwlujF ooDGphyufRsyxN6/PCDbmZ4YTblZF6QpyEJKE6nVZoXQ2p6KpdPtCfYnepCYOLNspDoN0/1OkgFyu 7033tLkJ3x4vcOPOucDxYTEnm88du9UqbSkwJFBfPJFQ+tdAB0zSomm7kNe2Bwypqk5RnaYHRdTcx 9eo+9vwXEj6ZZXm8SqWuQzy3aXaszVb2u0t8RzVkrYTLgSSksaeq/uzccyJnro/VtvR6cxk4fzJMa 0L8YQKn++i7y9iQHq5F++g==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pScoO-0007Hi-CN; Thu, 16 Feb 2023 06:52:28 -0500 In-Reply-To: <874jrmq6bw.fsf@yahoo.com> (message from Po Lu on Thu, 16 Feb 2023 17:59:15 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303401 Archived-At: > From: Po Lu > Cc: emacs-devel@gnu.org > Date: Thu, 16 Feb 2023 17:59:15 +0800 > > Eli Zaretskii writes: > > >> From: Po Lu > >> Cc: emacs-devel@gnu.org > >> Date: Thu, 16 Feb 2023 16:43:25 +0800 > >> > >> Eli Zaretskii writes: > >> > >> > Fix Haiku? A 'stat' call accesses the directory and file's meta-data, > >> > not the file itself, so what Haiku does makes no sense, IMO. > >> > > >> > But if you cannot fix Haiku, a suitable haiku-only change in > >> > file-equal-p, whereby the access times are exempt from comparison, is > >> > a possibility. > >> > >> Something like this? > > > > I'd prefer to have the original full comparison done first, and only > > if it fails, do the tailored comparison only for Haiku. That's > > because most systems don't need this, and so testing the condition in > > all cases will slow down those other systems. > > But here, the test is only done at all when (eq system-type 'haiku). It is still one more test, done for everyone.