From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Info-mode patch Date: Mon, 03 Jul 2023 21:57:59 +0300 Message-ID: <833524n7pk.fsf@gnu.org> References: <86wmzpqva6.fsf@mail.linkov.net> <867cropyh3.fsf@mail.linkov.net> <86mt0kulli.fsf@mail.linkov.net> <86wmzmzs1s.fsf@mail.linkov.net> <86edluyxhl.fsf@mail.linkov.net> <86bkgxfm34.fsf@mail.linkov.net> <86zg4gddtf.fsf@mail.linkov.net> <86v8f2xkr4.fsf@mail.linkov.net> <835y72noo4.fsf@gnu.org> <83zg4dmd4k.fsf@gnu.org> <83pm59m8vs.fsf@gnu.org> <86sfa46e1l.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4029"; mail-complaints-to="usenet@ciao.gmane.io" Cc: arthur.miller@live.com, emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jul 03 20:57:58 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qGOkI-0000nI-3Z for ged-emacs-devel@m.gmane-mx.org; Mon, 03 Jul 2023 20:57:58 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qGOjo-0002Sp-Je; Mon, 03 Jul 2023 14:57:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGOjm-0002Sc-Bt for emacs-devel@gnu.org; Mon, 03 Jul 2023 14:57:26 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGOjj-0006JA-5j; Mon, 03 Jul 2023 14:57:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=qYILAHzjZZqJsA4Ro71VK4ROF5p2+kEbQme9F0jZfzk=; b=hBXkxMDHzWCB Jx9L4Nyhqapi8XzdLK3UVMZFzEnQuwiv2KJJn2GGz6FfKUsdgNenXuuEgNOMOSNiM18qyoN1Rf+G9 PQd9N9sCltuZ+NeCEKyZ2LHfTa7dSUgnyOXHkKfb84Ti1y8c6fFiPt6SfNSo5otSEtnJzhxLaXyvB H0Cto1pm9KSlUIRRhdsMC9iYZ5ZgjAZwBIJhB3KRYTAB+tjqREfzfjwklumsBkKPJXqYQtXCU8SON BBjiOCNVp1sPJyYR4nktthkHxFh13hR+O5iJKctsUwl1mKTO3O1EELq3HqCNxRiNheXRU4ex5in6D RvPl8wV1jnBZJqcb6Ku0aQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGOjh-0002mu-89; Mon, 03 Jul 2023 14:57:22 -0400 In-Reply-To: <86sfa46e1l.fsf@mail.linkov.net> (message from Juri Linkov on Mon, 03 Jul 2023 21:40:10 +0300) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:307392 Archived-At: > From: Juri Linkov > Cc: Arthur Miller , emacs-devel@gnu.org > Date: Mon, 03 Jul 2023 21:40:10 +0300 > > >> >> >> It seems you found a bug in 'key-valid-p'! > >> >> >> And indeed it returns nil: > >> >> >> > >> >> >> (key-valid-p " ") > >> >> > > >> >> > Why is it a bug? " " has no meaning, > >> >> > since it isn't a mouse event. > >> >> > >> >> Is "remap" a mouse event? > >> > > >> > Why is "remap" relevant to the issue at hand? > >> > >> I converted from "old idiom" in info.el to new defvar-keymap. When > >> seeing "remap" (a dummy event) works, I just expected defvar-keymap was > >> done the way that it is possible to use all keys, fake-kyes, events, > >> and whatnot the same way. Similar as I expected 'frame to have same > >> meaning everywhere for the uniformity. > >> > >> Would look more tidy if it was possible to keep all key definitions in > >> the same place as in the old code. > > > > Do you mean that we had a binding like [tool-bar C-Back\ in\ history] > > somewhere? > > This symbol is generated automatically by 'easy-menu-define' > from the menu item "Back in History" with spaces inside. key-valid-p invalidates keys that have embedded whitespace, so we need to decide whether we want to add that or modify easy-menu-define to produce more reasonable symbols.