unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: andrewjmoreton@gmail.com, emacs-devel@gnu.org
Subject: Re: emacs-21.1.94 crash in gnus on Windows
Date: Sat, 20 Mar 2010 18:29:22 +0200	[thread overview]
Message-ID: <831vffhs7x.fsf@gnu.org> (raw)
In-Reply-To: <m2hbobt2s6.fsf@igel.home>

> From: Andreas Schwab <schwab@linux-m68k.org>
> Cc: Andy Moreton <andrewjmoreton@gmail.com>,  emacs-devel@gnu.org
> Date: Sat, 20 Mar 2010 16:45:45 +0100
> 
> I appears to happen when the last line in a buffer is made invisible
> with an elipsis spec (like the gnus-sum spec).

Last line in a buffer or last line on display?  Lines that are not
displayed should not be subject to any processing during redisplay.

> Apparently the code is accessing an uninitialized glyph row.

Do you mean that in the code below

	      if (TEXT_PROP_MEANS_INVISIBLE (prop) == 2)
		{
		  struct glyph_row *row = it.glyph_row;
		  struct glyph *glyph = row->glyphs[TEXT_AREA];
		  struct glyph *end = glyph + row->used[TEXT_AREA];
		  int x = row->x;

		  for (; glyph < end
			 && (!BUFFERP (glyph->object)
			     || glyph->charpos < charpos);
		       glyph++)
		    x += glyph->pixel_width;
		  top_x = x;
		}

it.glyph_row points to uninitialized memory?  That would be very
strange, since start_display and move_it_to, called just above this,
already worked on that glyph row.  Did I miss something?




  parent reply	other threads:[~2010-03-20 16:29 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-15 23:40 emacs-21.1.94 crash in gnus on Windows Andy Moreton
2010-03-16 10:33 ` Eli Zaretskii
2010-03-16 12:53   ` Andy Moreton
2010-03-16 15:26     ` David Kastrup
2010-03-16 20:34       ` Andy Moreton
2010-03-16 19:47     ` Eli Zaretskii
2010-03-16 20:42       ` Andy Moreton
2010-03-16 21:49         ` Eli Zaretskii
2010-03-20 12:19           ` Andreas Schwab
2010-03-20 15:45             ` Andreas Schwab
2010-03-20 16:20               ` Eli Zaretskii
2010-03-20 16:24               ` Andreas Schwab
2010-03-20 16:31                 ` Eli Zaretskii
2010-03-24 13:50                   ` Andy Moreton
2010-03-24 21:34                 ` Chong Yidong
2010-03-25  4:14                   ` Eli Zaretskii
2010-03-25 16:35                     ` Chong Yidong
2010-03-25 19:51                       ` Eli Zaretskii
2010-03-20 16:29               ` Eli Zaretskii [this message]
2010-03-20 16:46                 ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=831vffhs7x.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=andrewjmoreton@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).