From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Calling Lisp from undo.c's record_* functions Date: Tue, 17 Nov 2015 21:22:01 +0200 Message-ID: <831tbobfdy.fsf@gnu.org> References: <83r3jpc2of.fsf@gnu.org> <87h9kkbz6k.fsf@russet.org.uk> <87d1v8bsbf.fsf@russet.org.uk> <83bnasbnlq.fsf@gnu.org> <836110blpb.fsf@gnu.org> <8337w4bj53.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1447788153 27113 80.91.229.3 (17 Nov 2015 19:22:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 17 Nov 2015 19:22:33 +0000 (UTC) Cc: emacs-devel@gnu.org, phillip.lord@russet.org.uk To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 17 20:22:24 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zylpd-0005UZ-P6 for ged-emacs-devel@m.gmane.org; Tue, 17 Nov 2015 20:22:21 +0100 Original-Received: from localhost ([::1]:60368 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zylpd-0002eb-07 for ged-emacs-devel@m.gmane.org; Tue, 17 Nov 2015 14:22:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47805) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZylpP-0002eJ-KU for emacs-devel@gnu.org; Tue, 17 Nov 2015 14:22:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZylpL-00072S-Ld for emacs-devel@gnu.org; Tue, 17 Nov 2015 14:22:07 -0500 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:33451) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZylpL-00072M-Dz for emacs-devel@gnu.org; Tue, 17 Nov 2015 14:22:03 -0500 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NXZ00G004EVBR00@a-mtaout20.012.net.il> for emacs-devel@gnu.org; Tue, 17 Nov 2015 21:22:02 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NXZ00FKJ4GPWA80@a-mtaout20.012.net.il>; Tue, 17 Nov 2015 21:22:02 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.166 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:194665 Archived-At: > From: Stefan Monnier > Cc: phillip.lord@russet.org.uk, emacs-devel@gnu.org > Date: Tue, 17 Nov 2015 14:09:36 -0500 > > prepare_to_modify_buffer runs before-change-functions, so it's been > running Elisp code for many years. Maybe there are still problems > lurking, but I'm not too worried and they'd have to be fixed regardless > of what we do with run_undoable_change. I _am_ worried, and I think we should look into this now, and fix anything that needs fixing.