From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Recent commits break compilation for MinGW64
Date: Thu, 11 Feb 2016 22:40:41 +0200
Message-ID: <831t8j9e0m.fsf@gnu.org>
References: <loom.20160211T081708-249@post.gmane.org>
Reply-To: Eli Zaretskii <eliz@gnu.org>
NNTP-Posting-Host: plane.gmane.org
X-Trace: ger.gmane.org 1455223279 28051 80.91.229.3 (11 Feb 2016 20:41:19 GMT)
X-Complaints-To: usenet@ger.gmane.org
NNTP-Posting-Date: Thu, 11 Feb 2016 20:41:19 +0000 (UTC)
Cc: emacs-devel@gnu.org
To: Fabrice Popineau <fabrice.popineau@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 11 21:41:13 2016
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([208.118.235.17])
	by plane.gmane.org with esmtp (Exim 4.69)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1aTy34-0005l1-60
	for ged-emacs-devel@m.gmane.org; Thu, 11 Feb 2016 21:41:10 +0100
Original-Received: from localhost ([::1]:53399 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1aTy33-0002IO-LP
	for ged-emacs-devel@m.gmane.org; Thu, 11 Feb 2016 15:41:09 -0500
Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37218)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1aTy2o-0002I6-Ft
	for emacs-devel@gnu.org; Thu, 11 Feb 2016 15:40:55 -0500
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1aTy2j-0008Dm-FU
	for emacs-devel@gnu.org; Thu, 11 Feb 2016 15:40:54 -0500
Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60992)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1aTy2j-0008Di-CK; Thu, 11 Feb 2016 15:40:49 -0500
Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4939
	helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128)
	(Exim 4.82) (envelope-from <eliz@gnu.org>)
	id 1aTy2i-0005tr-N3; Thu, 11 Feb 2016 15:40:49 -0500
In-reply-to: <loom.20160211T081708-249@post.gmane.org> (message from Fabrice
	Popineau on Thu, 11 Feb 2016 07:20:32 +0000 (UTC))
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2001:4830:134:3::e
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:199773
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/199773>

> From: Fabrice Popineau <fabrice.popineau@gmail.com>
> Date: Thu, 11 Feb 2016 07:20:32 +0000 (UTC)
> 
> The commits 
> 456c0a3137bf58ee61a8e442cff0ca5d808e8d32
> and
> 25ec995c064d4e658fe3f9af084f120ae21a021a
> on lib-src/make-docfile.c
> break compilation for MinGW64.
> The use of va_start() and consorts
> requires
> #include <stdarg.h>
> at least for WINDOWSNT.

I think such commits shouldn't happen at all on emacs-25, but on
master.  IMO, the time for cleanups on the release branch has come and
gone.