From: Eli Zaretskii <eliz@gnu.org>
To: Richard Copley <rcopley@gmail.com>
Cc: halley@play-bow.org, eggert@cs.ucla.edu, emacs-devel@gnu.org
Subject: Re: unexmacosx.c and limits.h problem
Date: Sat, 17 Sep 2016 16:38:28 +0300 [thread overview]
Message-ID: <831t0i4pez.fsf@gnu.org> (raw)
In-Reply-To: <CAPM58oikQkcsHb0HBxz1-_00YtLfVCmdELzZKm5_B9WNV=HeHg@mail.gmail.com> (message from Richard Copley on Sat, 17 Sep 2016 13:56:03 +0100)
> From: Richard Copley <rcopley@gmail.com>
> Date: Sat, 17 Sep 2016 13:56:03 +0100
> Cc: Paul Eggert <eggert@cs.ucla.edu>, Bob Halley <halley@play-bow.org>,
> Emacs Development <emacs-devel@gnu.org>
>
> > I added an #error to limits.h; as you can see from the output below,
> > limits.h is already included via the system stdlib.h, which is
> > included near the top of w32proc.c, so the direct #include of limits.h
> > after config.h in w32proc.c has no effect.
> >
> > In file included from
> > C:/msys64/mingw64/x86_64-w64-mingw32/include/stdlib.h:10:0,
> > from G:/emacs/repo/emacs/src/w32proc.c:27:
> > ../lib/limits.h:21:2: error: #error limits
> > #error limits
> > ^~~~~
>
> This is similar to what Bob said in his original message,
>
> > The reason other code works is because it #include <config.h> which
> > defines it before including <limits.h>, but unexmacosx.c includes
> > <stdlib.h> before > including <config.h> for reasons it describes,
> > and this causes <limits.h> to get included as well.
Which to me sounds like lib/limits.h is not a good place to define
these constants, or at least Emacs shouldn't rely on Gnulib's limits.h
to do its magic on all systems.
Paul?
next prev parent reply other threads:[~2016-09-17 13:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 23:04 unexmacosx.c and limits.h problem Bob Halley
2016-09-17 1:02 ` Paul Eggert
2016-09-17 11:03 ` Richard Copley
2016-09-17 11:18 ` Eli Zaretskii
2016-09-17 11:28 ` Richard Copley
2016-09-17 11:31 ` Richard Copley
2016-09-17 11:51 ` Eli Zaretskii
2016-09-17 12:28 ` Richard Copley
2016-09-17 12:40 ` Richard Copley
2016-09-17 12:56 ` Richard Copley
2016-09-17 13:38 ` Eli Zaretskii [this message]
2016-09-17 18:14 ` Paul Eggert
2016-09-17 12:41 ` Eli Zaretskii
2016-09-17 12:46 ` Richard Copley
2016-09-17 11:34 ` Eli Zaretskii
2016-09-17 11:38 ` Richard Copley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831t0i4pez.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=halley@play-bow.org \
--cc=rcopley@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).