unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: npostavs@users.sourceforge.net
Cc: emacs-devel@gnu.org
Subject: Re: Some proposed backports from master to emacs-25
Date: Sun, 02 Oct 2016 17:54:54 +0300	[thread overview]
Message-ID: <831szyrebl.fsf@gnu.org> (raw)
In-Reply-To: <87shseyhfl.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net)

> From: npostavs@users.sourceforge.net
> Date: Sun, 02 Oct 2016 10:05:50 -0400
> 
> I had marked some bugs as fixed in 25.2 and pushed to master because I
> didn't know at the time it was going to be 26.  I think there were some
> others working under the same assumption, so I've gathered those fixes
> to backport in a semi-automated fashion by searching commit messages in
> the range emacs-25..master for non-wishlist bugs marked fixed in 25.2,

Could you please provide a short explanation why you think each of the
backports should be in 25.2?  I've looked through the log messages,
and couldn't figure that out easily.

In general, since we want 25.2 released quickly, I think the criteria
for back-porting should be somewhat rigid, something like:

  . any doc fixes
  . regressions from 24.5
  . problems introduced in features new in 25.1

> (defvar backporting-fixed-bug-list
>   (debbugs-get-bugs :status "done" :tag "fixed"
>                     :archive "both"))
> 
> (defvar backporting-fixed-bug-status-list
>   (apply #'debbugs-get-status backporting-fixed-bug-list))
> 
> (defun backporting-fixed-25.2-bug-list ()
>     (cl-loop for bug in backporting-fixed-bug-status-list
>              if (and (member "25.2" (cdr (assq 'fixed_versions bug)))
>                      (not (equal "wishlist" (cdr (assq 'severity bug)))))
>              collect (cdr (assq 'id bug))))

That looks quite a bit more than the above criteria, but maybe I'm
missing something.

Thanks.



  reply	other threads:[~2016-10-02 14:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-02 14:05 Some proposed backports from master to emacs-25 npostavs
2016-10-02 14:54 ` Eli Zaretskii [this message]
2016-10-02 16:40   ` Noam Postavsky
2016-10-03  7:06     ` Eli Zaretskii
2016-10-03 22:59 ` Noam Postavsky
2016-10-04  6:07   ` David Engster
2016-10-04  6:34   ` Eli Zaretskii
2016-10-04  6:51     ` David Engster
2016-10-04  7:54       ` Eli Zaretskii
2016-10-04 12:02         ` Noam Postavsky
2016-10-04 12:18           ` Eli Zaretskii
2016-10-07  1:42             ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=831szyrebl.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=npostavs@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).