From: Eli Zaretskii <eliz@gnu.org>
To: Tino Calancha <tino.calancha@gmail.com>
Cc: jwiegley@gmail.com, czipperz@gmail.com, rms@gnu.org, emacs-devel@gnu.org
Subject: Re: Reformat all of src/
Date: Thu, 29 Dec 2016 18:15:48 +0200 [thread overview]
Message-ID: <831swqvhhn.fsf@gnu.org> (raw)
In-Reply-To: <alpine.DEB.2.20.1612292053100.18396@calancha-pc> (message from Tino Calancha on Thu, 29 Dec 2016 21:04:13 +0900 (JST))
> From: Tino Calancha <tino.calancha@gmail.com>
> Date: Thu, 29 Dec 2016 21:04:13 +0900 (JST)
> cc: rms@gnu.org, jwiegley@gmail.com, czipperz@gmail.com, emacs-devel@gnu.org
>
> > We arrived at the current convention of not doing such changes unless
> > real code changes are also committed based on our practice, so I don't
> > think we should reverse that decision.
> Is just a voluntary convention? Is is prefered or discouraged?
I think you will generally get responses such as you've seen for any
patch suggestion that only changes whitespace.
> If the former, then we might encourage it adding some instructions
> in CONTRIBUTE about when/how do this thing.
It probably should be in CONTRIBUTE, yes. I think the reason it isn't
is that this issue doesn't pop up too frequently.
> When i am changing a function which uses tabs for indentation, i
> think that is a good opportunity to change such func. to use white
> spaces instead.
That is a separate issue: whether C sources should use the default
TABs and SPACEs indentation or just SPACEs. I think we agreed to
disagree about that, and that's why .dir-locals.el doesn't say
anything about the C mode, so that everyone could use the settings
they have in their .emacs.
next prev parent reply other threads:[~2016-12-29 16:15 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-28 0:59 Reformat all of src/ Chris Gregory
2016-12-28 3:43 ` Stefan Monnier
2016-12-28 4:45 ` John Wiegley
2016-12-28 4:52 ` Chris Gregory
2016-12-28 5:01 ` Chris Gregory
2016-12-28 12:58 ` Phillip Lord
2016-12-28 15:35 ` John Yates
2016-12-28 15:39 ` Lars Ingebrigtsen
2016-12-28 16:01 ` John Yates
2016-12-28 16:27 ` Lars Ingebrigtsen
2016-12-28 16:17 ` Phillip Lord
2016-12-28 17:19 ` Stefan Monnier
2016-12-28 17:35 ` Phillip Lord
2016-12-28 17:52 ` Stefan Monnier
2016-12-28 17:59 ` Eli Zaretskii
2016-12-28 16:32 ` Yuri Khan
2016-12-28 16:37 ` Lars Ingebrigtsen
2016-12-28 16:56 ` Yuri Khan
2016-12-28 16:59 ` John Wiegley
2016-12-28 17:12 ` Yuri Khan
2016-12-28 17:20 ` Phillip Lord
2016-12-28 18:38 ` Paul Eggert
2016-12-29 1:10 ` Dmitry Gutov
2016-12-29 5:53 ` Paul Eggert
2016-12-29 11:28 ` Dmitry Gutov
2016-12-30 1:07 ` Paul Eggert
2016-12-30 10:34 ` Phillip Lord
2017-01-01 1:14 ` Dmitry Gutov
2016-12-29 13:18 ` Phillip Lord
2016-12-29 16:17 ` Eli Zaretskii
2016-12-29 17:18 ` John Covici
2016-12-29 17:19 ` John Covici
2016-12-30 10:30 ` Phillip Lord
2016-12-28 17:23 ` John Yates
2016-12-31 10:23 ` Philippe Vaucher
2016-12-29 1:36 ` Richard Stallman
2016-12-29 3:41 ` Eli Zaretskii
2016-12-29 12:04 ` Tino Calancha
2016-12-29 16:15 ` Eli Zaretskii [this message]
2016-12-30 0:09 ` Richard Stallman
2016-12-30 8:21 ` Eli Zaretskii
2016-12-29 14:39 ` Stefan Monnier
2016-12-28 10:27 ` hector
-- strict thread matches above, loose matches on Subject: below --
2016-12-29 2:08 Chris Gregory
2016-12-29 3:38 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831swqvhhn.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=czipperz@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=jwiegley@gmail.com \
--cc=rms@gnu.org \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).