From: Eli Zaretskii <eliz@gnu.org>
To: Tino Calancha <tino.calancha@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: dired-tests.el fails on MS-Windows
Date: Fri, 04 Aug 2017 16:14:18 +0300 [thread overview]
Message-ID: <831sorxyol.fsf@gnu.org> (raw)
In-Reply-To: <alpine.DEB.2.20.1708041417570.29088@calancha-pc> (message from Tino Calancha on Fri, 4 Aug 2017 14:21:01 +0900 (JST))
> From: Tino Calancha <tino.calancha@gmail.com>
> Date: Fri, 4 Aug 2017 14:21:01 +0900 (JST)
> cc: Tino Calancha <tino.calancha@gmail.com>,
> Emacs developers <emacs-devel@gnu.org>
>
> > maybe if you could explain the idea behind the code I could think of a
> > reason why it doesn't work here.
> I added more comments and sanity checks in commit
> db5d38ddb0de83d8f920b7a128fe3fd5156fdf85
> (Fix 2 tests that fail in MS-Windows)
> Does it work now in Windows?
It didn't, but given the comments I've now succeeded to understand the
idea of dired-test-bug25609, and fixed it.
dired-test-bug27631 still fails, and it fails because of this:
(setq buf (dired (expand-file-name "dir*/*.txt" dir)))
ls-lisp signals an error here:
wrong-type-argument listp "dir*/*.txt"
Didn't you add a feature lately that should support this in ls-lisp?
I guess that feature needs to be turned on for this test to pass on
Windows.
next prev parent reply other threads:[~2017-08-04 13:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 15:22 dired-tests.el fails on MS-Windows Eli Zaretskii
2017-08-01 17:02 ` Tino Calancha
2017-08-01 19:04 ` Eli Zaretskii
2017-08-01 20:56 ` Fabrice Popineau
2017-08-02 6:44 ` Tino Calancha
2017-08-04 13:18 ` Eli Zaretskii
2017-08-04 13:30 ` Fabrice Popineau
2017-08-04 13:44 ` Tino Calancha
2017-08-04 14:01 ` Fabrice Popineau
2017-08-04 14:00 ` Eli Zaretskii
2017-08-04 5:21 ` Tino Calancha
2017-08-04 13:14 ` Eli Zaretskii [this message]
2017-08-04 13:39 ` Tino Calancha
2017-08-04 14:23 ` Fabrice Popineau
2017-08-04 14:39 ` Fabrice Popineau
2017-08-04 14:49 ` Tino Calancha
2017-08-04 14:58 ` Fabrice Popineau
2017-08-04 15:10 ` Tino Calancha
2017-08-01 20:52 ` Fabrice Popineau
2017-08-02 3:38 ` Tino Calancha
2017-08-02 6:31 ` Michael Albinus
2017-08-02 7:59 ` Tino Calancha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831sorxyol.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).