From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-26 ee512e9: Ignore buffers whose name begins with a space in save-some-buffers Date: Thu, 21 Sep 2017 11:01:26 +0300 Message-ID: <831sn0fpk9.fsf@gnu.org> References: <20170918202953.21378.63492@vcs0.savannah.gnu.org> <20170918202955.5043420AC4@vcs0.savannah.gnu.org> <87inge8skl.fsf@ericabrahamsen.net> <878th9z40r.fsf@ericabrahamsen.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1505980937 3533 195.159.176.226 (21 Sep 2017 08:02:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 21 Sep 2017 08:02:17 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eric Abrahamsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 21 10:02:06 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1duwQs-000074-KA for ged-emacs-devel@m.gmane.org; Thu, 21 Sep 2017 10:02:02 +0200 Original-Received: from localhost ([::1]:52259 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1duwR0-0002bl-1k for ged-emacs-devel@m.gmane.org; Thu, 21 Sep 2017 04:02:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37063) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1duwQV-0002bd-3c for emacs-devel@gnu.org; Thu, 21 Sep 2017 04:01:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1duwQP-0005Yc-Ev for emacs-devel@gnu.org; Thu, 21 Sep 2017 04:01:39 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58259) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1duwQP-0005YP-BO; Thu, 21 Sep 2017 04:01:33 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4203 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1duwQO-0004xQ-KJ; Thu, 21 Sep 2017 04:01:33 -0400 In-reply-to: <878th9z40r.fsf@ericabrahamsen.net> (message from Eric Abrahamsen on Wed, 20 Sep 2017 10:14:12 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:218624 Archived-At: > From: Eric Abrahamsen > Date: Wed, 20 Sep 2017 10:14:12 -0700 > > > How about this as a solution? With this, you only need to set buffer-over-save. > > > > diff --git a/lisp/files.el b/lisp/files.el > > index 0c30d40c13..5c05e3168b 100644 > > --- a/lisp/files.el > > +++ b/lisp/files.el > > @@ -5188,15 +5188,15 @@ save-some-buffers > > (and (buffer-live-p buffer) > > (buffer-modified-p buffer) > > (not (buffer-base-buffer buffer)) > > - (not (eq (aref (buffer-name buffer) 0) ?\s)) > > (or > > (buffer-file-name buffer) > > (and pred > > (progn > > (set-buffer buffer) > > (and buffer-offer-save (> (buffer-size) 0)))) > > - (buffer-local-value > > - 'write-contents-functions buffer)) > > + (and buffer-offer-save > > + (buffer-local-value > > + 'write-contents-functions buffer))) > > (or (not (functionp pred)) > > (with-current-buffer buffer (funcall pred))) > > (if arg > > > > Stefan? Eli? > > As far as I can see, that's a good solution. Let's see what they say. Are there any upsides and downsides to consider wrt this solution? If so, what are they? Thanks.