From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: New Flymake rewrite in emacs-26 Date: Tue, 10 Oct 2017 17:18:11 +0300 Message-ID: <831smbqe70.fsf@gnu.org> References: <8760bwz5qf.fsf@gmail.com> <83infw1dkz.fsf@gnu.org> <87efqbb35x.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1507645179 26547 195.159.176.226 (10 Oct 2017 14:19:39 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 10 Oct 2017 14:19:39 +0000 (UTC) Cc: sdl.web@gmail.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: joaotavora@gmail.com (=?utf-8?B?Sm/Do28gVMOhdm9yYQ==?=) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 10 16:19:34 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1vNW-0005Oa-N7 for ged-emacs-devel@m.gmane.org; Tue, 10 Oct 2017 16:19:26 +0200 Original-Received: from localhost ([::1]:35320 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e1vNe-0003N6-44 for ged-emacs-devel@m.gmane.org; Tue, 10 Oct 2017 10:19:34 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46537) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e1vMs-0003LF-G9 for emacs-devel@gnu.org; Tue, 10 Oct 2017 10:18:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e1vMn-0006SP-Tc for emacs-devel@gnu.org; Tue, 10 Oct 2017 10:18:46 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54729) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e1vMZ-0006JA-Hc; Tue, 10 Oct 2017 10:18:27 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2131 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e1vMY-0006tV-Tp; Tue, 10 Oct 2017 10:18:27 -0400 In-reply-to: <87efqbb35x.fsf@gmail.com> (joaotavora@gmail.com) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:219337 Archived-At: > From: joaotavora@gmail.com (João Távora) > Cc: emacs-devel@gnu.org, sdl.web@gmail.com, monnier@iro.umontreal.ca > Date: Tue, 10 Oct 2017 13:25:30 +0100 > > Eli Zaretskii writes: > > > We should add some minimal documentation about the new features. > > I added this to doc/misc/flymake.texi. It needs proofreading, but > otherwise I consider it a fairly complete description of the new API. Thanks, I've proofread it and made several fixes, please take a look. (I can explain each change I made, if it is not immediately apparent from the change itself or the log message.) > > This should be in NEWS, perhaps after adjusting the style a bit. > > I'm not great at summarizing changes in a NEWS-snazzy manner, but a > patch is attached. Looks good, see a couple of minor comments below. > Apart from that, I see these loose ends: > > * Are we keeping track of the Flymake backends developed by people? You mean, in the manual? I'd prefer not to, since such information quickly becomes obsolete, and keeping it up to date imposes a maintenance burden we'd better avoided. If you mean track them somewhere else, please tell. > * Should Flymake do something with next-error-function? I thought it already did? > * There is a "Flymake diagnostics buffer" sub-feature in > scratch/flymake-diagnostics-buffer. It is reasonably stable. Is it > OK to merge into emacs-26? If it's easy to show a diff for such a merge, please do. > * Shouldn't flymake.texi be split into two parts, one for the Emacs > manual and another for Emacs Lisp manual? It doesn't seem worth the hassle. Most users will be programmers anyway. > +*** Flymake has been completely redesigned > + > +Flymake now annotates arbitrary buffer regions, not just lines. It > +supports arbitrary diagnostic types, not not just errors and warnings ^^^ Extra "not". > + Backends for Emacs-lisp mode are > +provided. I think this should be in single. And the correct spelling is "Emacs Lisp mode". Also, please use our convention of keeping 2 spaces between sentences. Otherwise, please push these changes, and thanks.