From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: What's the right way to detect libxml2? Date: Fri, 03 Nov 2017 11:36:06 +0200 Message-ID: <831slfwvp5.fsf@gnu.org> References: <7f80cde1944261b7ee29020ff953f14c.squirrel@cloud103.planethippo.com> <36e54d52-99b2-ae53-2b36-99d06eb53d15@gmail.com> <877evkfpe1.fsf@gmail.com> <873767fp1p.fsf@gmail.com> <83wp3f63jk.fsf@gnu.org> <87d155aul2.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1509701785 846 195.159.176.226 (3 Nov 2017 09:36:25 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 3 Nov 2017 09:36:25 +0000 (UTC) Cc: emacs-devel@gnu.org To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 03 10:36:18 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAYOb-0007sM-RE for ged-emacs-devel@m.gmane.org; Fri, 03 Nov 2017 10:36:13 +0100 Original-Received: from localhost ([::1]:35602 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eAYOj-0000ce-9Y for ged-emacs-devel@m.gmane.org; Fri, 03 Nov 2017 05:36:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59395) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eAYOd-0000b7-IZ for emacs-devel@gnu.org; Fri, 03 Nov 2017 05:36:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eAYOX-0002I2-Mb for emacs-devel@gnu.org; Fri, 03 Nov 2017 05:36:15 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43300) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eAYOX-0002Hy-JW; Fri, 03 Nov 2017 05:36:09 -0400 Original-Received: from [176.228.60.248] (port=1676 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eAYOW-00084J-SU; Fri, 03 Nov 2017 05:36:09 -0400 In-reply-to: <87d155aul2.fsf@gmail.com> (message from Robert Pluim on Mon, 30 Oct 2017 09:49:45 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:219879 Archived-At: > From: Robert Pluim > Cc: andrewjmoreton@gmail.com, emacs-devel@gnu.org > Date: Mon, 30 Oct 2017 09:49:45 +0100 > > > This is okay for the master branch, but please also add a NEWS entry > > about the new function, and the fact that from now on the detection of > > libxml2 availability should use that. > > Attached, as I don't have commit privileges, and I don't know whether > my copyright assignment has finished being processed yet. Thanks, pushed to the master branch. A comment for the future: please always end the log en tries with a period, to make them complete sentences. Like this: * src/emacs.c (main): Call syms_of_xml unconditionally. * src/lisp.h: Provide syms_of_xml prototype even when HAVE_LIBXML2 is not defined. * src/xml.c (Flibxml_available_p): New function, cloned from Fgnutls_available_p. (syms_of_xml): Provide Slibxml_available_p.