unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Rami Ylimäki" <rami.ylimaki@vincit.fi>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH 0/1] Proper 24-bit TTY detection for Emacs 26.
Date: Wed, 24 Jan 2018 20:39:47 +0200	[thread overview]
Message-ID: <831sifnlsc.fsf@gnu.org> (raw)
In-Reply-To: <20180123200536.26554-1-rami.ylimaki@vincit.fi> (message from Rami Ylimäki on Tue, 23 Jan 2018 22:05:35 +0200)

> From: Rami Ylimäki <rami.ylimaki@vincit.fi>
> Date: Tue, 23 Jan 2018 22:05:35 +0200
> 
> Hi, I thought that it would make sense to fix this before official
> release. Terminfo has just recently started to support capabilites for
> detecting 24-bit terminals.

It's too late to make incompatible changes on the emacs-26 branch.

I actually don't understand the motivation for the change.  Did the
method we use now stop working in the recent versions of terminfo, and
the "RGB" and "setaf"/"setab" replace "setf24"/"setb24" we use in the
current code?  Or are the new attributes supported in addition to the
old ones?  If the latter, why do we need to change anything?  And if
the former, I think we want to support both, not just the new
replacements.

Thanks.



  parent reply	other threads:[~2018-01-24 18:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-23 20:05 [PATCH 0/1] Proper 24-bit TTY detection for Emacs 26 Rami Ylimäki
2018-01-23 20:05 ` [PATCH 1/1] Detect 24-bit TTY color support with standard Terminfo capabilites Rami Ylimäki
2018-01-24 18:39 ` Eli Zaretskii [this message]
2018-01-29 13:27   ` [PATCH 0/1] Proper 24-bit TTY detection for Emacs 26 Rami Ylimäki
2018-01-29 15:59     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=831sifnlsc.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=rami.ylimaki@vincit.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).