From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 934a72c: User can specify files never subject t Date: Tue, 05 Jun 2018 17:52:48 +0300 Message-ID: <831sdlb7zz.fsf@gnu.org> References: <87h8mif6hs.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1528210247 28431 195.159.176.226 (5 Jun 2018 14:50:47 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 5 Jun 2018 14:50:47 +0000 (UTC) Cc: sds@gnu.org, emacs-devel@gnu.org To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 05 16:50:43 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQDIE-0007C1-IN for ged-emacs-devel@m.gmane.org; Tue, 05 Jun 2018 16:50:38 +0200 Original-Received: from localhost ([::1]:47312 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fQDKL-0005Gn-Mx for ged-emacs-devel@m.gmane.org; Tue, 05 Jun 2018 10:52:49 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49862) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fQDKF-0005GS-0a for emacs-devel@gnu.org; Tue, 05 Jun 2018 10:52:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fQDKB-0002pz-Ug for emacs-devel@gnu.org; Tue, 05 Jun 2018 10:52:43 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45097) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fQDKA-0002pN-5o; Tue, 05 Jun 2018 10:52:38 -0400 Original-Received: from [176.228.60.248] (port=3875 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fQDK9-00039l-Ka; Tue, 05 Jun 2018 10:52:38 -0400 In-reply-to: <87h8mif6hs.fsf@gmail.com> (message from =?utf-8?B?Sm/Do28g?= =?utf-8?B?VMOhdm9yYQ==?= on Tue, 05 Jun 2018 00:59:27 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:226030 Archived-At: > From: João Távora > Date: Tue, 05 Jun 2018 00:59:27 +0100 > Cc: emacs-devel@gnu.org > > I was going through Flymake in master to perform some refactorings when > I came across this change: > > commit 934a72c7e4a506a36697fdb98f837cea989e70e1 > Author: Sam Steingold > Date: Wed Nov 1 09:36:41 2017 -0400 > > User can specify files never subject to flymake. > > There was some discussion around it > > https://lists.gnu.org/archive/html/emacs-devel/2017-11/msg00054.html > > but I believe we later agreed (though off-list for some reason) that > using a file or dir-local value of nil for > `flymake-diagnostic-functions' is a much better alternative in Emacs > 26.1 onwards. In the case of your "mini-scratch" Python files, just add: > > # Local Variables: > # flymake-diagnostic-functions: nil > # End: > > So, do you mind if I revert the patch? I'm asking because new > user-visible complexity in a file I'm trying to refactor is > counterproductive to that task. So we introduced a defcustom in Emacs 26.1 just to remove it in Emacs 27.1? Isn't there a nicer way out of this, one that doesn't remove an existing feature?