From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Replace trivial pcase occurrences in the Emacs sources Date: Mon, 29 Oct 2018 05:26:52 +0200 Message-ID: <831s89mo03.fsf@gnu.org> References: <20151216202605.GA3752@acm.fritz.box> <56892334.4000106@yandex.ru> <8760zakb7q.fsf@fencepost.gnu.org> <56892BDA.6060103@dancol.org> <871t9yk98g.fsf@fencepost.gnu.org> <568936F0.3060505@yandex.ru> <87wprqitj5.fsf@fencepost.gnu.org> <56893C8C.3060200@yandex.ru> <87oad2irtd.fsf@fencepost.gnu.org> <5689456A.1010601@yandex.ru> <87egdy8tyz.fsf@fencepost.gnu.org> <56895FDE.4060406@yandex.ru> <8760za8r4a.fsf@fencepost.gnu.org> <87h9iunkcg.fsf@web.de> <87h8hc4xw2.fsf_-_@web.de> <83tvlcsnee.fsf@gnu.org> <87pnw037ar.fsf@web.de> <83ftwvs7y9.fsf@gnu.org> <877ei7mkfh.fsf@web.de> <87a7mze7tl.fsf@web.de> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1540783488 28087 195.159.176.226 (29 Oct 2018 03:24:48 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 29 Oct 2018 03:24:48 +0000 (UTC) Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Michael Heerdegen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 29 04:24:44 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGyAV-0007Bp-2E for ged-emacs-devel@m.gmane.org; Mon, 29 Oct 2018 04:24:43 +0100 Original-Received: from localhost ([::1]:43373 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gGyCb-0005MM-AC for ged-emacs-devel@m.gmane.org; Sun, 28 Oct 2018 23:26:53 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36834) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gGyCV-0005MF-K5 for emacs-devel@gnu.org; Sun, 28 Oct 2018 23:26:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gGyCS-0004X2-C7 for emacs-devel@gnu.org; Sun, 28 Oct 2018 23:26:47 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59220) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gGyCS-0004Ww-8K; Sun, 28 Oct 2018 23:26:44 -0400 Original-Received: from [176.228.60.248] (port=2912 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gGyCR-0000Js-R0; Sun, 28 Oct 2018 23:26:44 -0400 In-reply-to: <87a7mze7tl.fsf@web.de> (message from Michael Heerdegen on Sat, 27 Oct 2018 17:19:02 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:230762 Archived-At: > From: Michael Heerdegen > Cc: Stefan Monnier , emacs-devel@gnu.org > Date: Sat, 27 Oct 2018 17:19:02 +0200 > > Is the commit message ok as it is? Or should I list the changed files > to say "All callers changed" every time? I'd prefer this format: * lisp/char-fold.el: * lisp/dired.el: * lisp/emacs-lisp/derived.el: * lisp/emacs-lisp/easy-mmode.el: Don't quote self-quoting 'pcase' patterns. IOW, a list of all changed files, with the description at the end. Thanks.