From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Identifying the face between STRETCH and right fringe. Date: Tue, 27 Nov 2018 20:55:01 +0200 Message-ID: <831s76gxkq.fsf@gnu.org> References: <83h8gbis2d.fsf@gnu.org> <83zhu0f6tt.fsf@gnu.org> <83sgzrgb1f.fsf@gnu.org> <83r2fbg5bq.fsf@gnu.org> <83lg5jfs9o.fsf@gnu.org> <83a7luhnid.fsf@gnu.org> <838t1ehi6v.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1543345127 437 195.159.176.226 (27 Nov 2018 18:58:47 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 27 Nov 2018 18:58:47 +0000 (UTC) Cc: emacs-devel@gnu.org To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 27 19:58:42 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gRiZD-0008Oc-Ua for ged-emacs-devel@m.gmane.org; Tue, 27 Nov 2018 19:58:40 +0100 Original-Received: from localhost ([::1]:44047 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRibK-0002Eu-C2 for ged-emacs-devel@m.gmane.org; Tue, 27 Nov 2018 14:00:50 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54787) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRiVc-0005Vz-9V for emacs-devel@gnu.org; Tue, 27 Nov 2018 13:54:57 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRiVZ-0001vP-43 for emacs-devel@gnu.org; Tue, 27 Nov 2018 13:54:56 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58533) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRiVZ-0001vH-0k; Tue, 27 Nov 2018 13:54:53 -0500 Original-Received: from [176.228.60.248] (port=1954 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gRiVY-0007hU-L3; Tue, 27 Nov 2018 13:54:52 -0500 In-reply-to: (message from Robert Pluim on Tue, 27 Nov 2018 14:55:23 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231455 Archived-At: > From: Robert Pluim > Cc: emacs-devel@gnu.org > Date: Tue, 27 Nov 2018 14:55:23 +0100 > > >> When we get here, face->background == 1, and FRAME_BACKGROUND_PIXEL == > >> 0xfffeffff > >> > >> Looking through nsfns.m, the problem becomes obvious: the NS port uses > >> indices into a color table to specify the background colour of faces, > >> and FRAME_BACKGROUND_PIXEL is an RGBA value. > > > > Why does NS use indices here, and not RGBA values? > > Probably because NS doesnʼt really use the RGBA values directly at > all, but uses the indices all the time. So where does the RGBA value in FRAME_BACKGROUND_PIXEL come from? > > If no better/cleaner idea emerges, how about having an NS-specific > > code here that computed the it->face's background RGBA by indexing > > into the color table, before comparing that with > > FRAME_BACKGROUND_PIXEL? > > Thatʼs doable. Thanks. Note that there are a couple more of such comparisons, so perhaps a macro is in order, with different implementations for NS and the rest.