From: Eli Zaretskii <eliz@gnu.org>
To: alan@idiocy.org
Cc: eggert@cs.ucla.edu, dancol@dancol.org, emacs-devel@gnu.org
Subject: Re: pdumper bootstrap error
Date: Tue, 22 Jan 2019 18:49:45 +0200 [thread overview]
Message-ID: <831s54ab86.fsf@gnu.org> (raw)
In-Reply-To: <837eex9xm3.fsf@gnu.org> (message from Eli Zaretskii on Tue, 22 Jan 2019 05:31:32 +0200)
> Date: Tue, 22 Jan 2019 05:31:32 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: eggert@cs.ucla.edu, dancol@dancol.org, emacs-devel@gnu.org
>
> > If I comment out this:
> >
> > $(srcdir)/macuvs.h $(lispsource)/international/charprop.el: \
> > bootstrap-emacs$(EXEEXT) $(bootstrap_pdmp) FORCE
> > $(MAKE) -C ../admin/unidata all EMACS="../$(bootstrap_exe)"
> >
> > the errors go away.
>
> You mean, the problem with the wrong fingerprint also goes away? If
> so, perhaps the missing part of your build is because Make throws away
> the dependency I've shown, and we need to rework the dependencies not
> to cause this.
Could you please try the patch below? It reverts your "cp -f"
addition, and instead attempts to avoid the circular dependency that I
think is the root cause of all this.
diff --git a/src/Makefile.in b/src/Makefile.in
index e0b7e3d..8adbf75 100644
--- a/src/Makefile.in
+++ b/src/Makefile.in
@@ -526,7 +526,7 @@ LIBES = $(LIBS) $(W32_LIBS) $(LIBS_GNUSTEP) $(LIBX_BASE) $(LIBIMAGE) \
## and emacs (which recreates bootstrap-emacs) depends on charprop,
## in practice this rule was always run anyway.
$(srcdir)/macuvs.h $(lispsource)/international/charprop.el: \
- bootstrap-emacs$(EXEEXT) $(bootstrap_pdmp) FORCE
+ FORCE | bootstrap-emacs$(EXEEXT) $(bootstrap_pdmp)
$(MAKE) -C ../admin/unidata all EMACS="../$(bootstrap_exe)"
## We require charprop.el to exist before ucs-normalize.el is
@@ -565,7 +565,6 @@ ifeq ($(DUMPING),unexec)
cp -f $@ bootstrap-emacs$(EXEEXT)
else
rm -f $@ && cp -f temacs$(EXEEXT) $@
- cp -f $@ bootstrap-emacs$(EXEEXT)
endif
ifeq ($(DUMPING),pdumper)
next prev parent reply other threads:[~2019-01-22 16:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-19 22:25 pdumper bootstrap error Alan Third
2019-01-19 22:38 ` Philipp Stephani
2019-01-19 22:52 ` Paul Eggert
2019-01-20 10:57 ` Alan Third
2019-01-21 16:53 ` Alan Third
2019-01-21 17:18 ` Eli Zaretskii
2019-01-21 19:07 ` Eli Zaretskii
2019-01-21 19:50 ` Alan Third
2019-01-21 19:43 ` Alan Third
2019-01-21 20:33 ` Eli Zaretskii
2019-01-21 21:20 ` Alan Third
2019-01-22 3:31 ` Eli Zaretskii
2019-01-22 16:49 ` Eli Zaretskii [this message]
2019-01-22 23:20 ` Alan Third
2019-01-23 16:24 ` Eli Zaretskii
2019-01-23 19:47 ` Alan Third
2019-01-23 19:56 ` Eli Zaretskii
2019-01-25 22:17 ` Alan Third
2019-01-22 17:14 ` Alan Third
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831s54ab86.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=alan@idiocy.org \
--cc=dancol@dancol.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).