From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [Emacs-diffs] master 1072155: Avoid duplicate entries in
	process-environment after re-dumping
Date: Wed, 03 Apr 2019 20:32:26 +0300
Message-ID: <831s2jdmfp.fsf@gnu.org>
References: <20190321155613.6127.22574@vcs0.savannah.gnu.org>
	<20190321155614.E6343209B2@vcs0.savannah.gnu.org>
	<892097f7bc3f5e0ac88d31c60e0bed59.squirrel@dancol.org>
	<834l7gfbxn.fsf@gnu.org>
	<369aae77db760bfe079e47254470001d.squirrel@dancol.org>
	<83h8bfe94g.fsf@gnu.org>
	<2f59c1ff3d4ad006c09634813e6724b8.squirrel@dancol.org>
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="224324"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: emacs-devel@gnu.org
To: "Daniel Colascione" <dancol@dancol.org>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 03 19:32:24 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hBjkM-000wAW-Tt
	for ged-emacs-devel@m.gmane.org; Wed, 03 Apr 2019 19:32:23 +0200
Original-Received: from localhost ([127.0.0.1]:42601 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hBjkL-000061-Tj
	for ged-emacs-devel@m.gmane.org; Wed, 03 Apr 2019 13:32:21 -0400
Original-Received: from eggs.gnu.org ([209.51.188.92]:45093)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1hBjkD-00004q-QT
	for emacs-devel@gnu.org; Wed, 03 Apr 2019 13:32:14 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58125)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1hBjkD-0003MR-Ju; Wed, 03 Apr 2019 13:32:13 -0400
Original-Received: from [176.228.60.248] (port=1327 helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.82) (envelope-from <eliz@gnu.org>)
	id 1hBjkC-00019R-TT; Wed, 03 Apr 2019 13:32:13 -0400
In-reply-to: <2f59c1ff3d4ad006c09634813e6724b8.squirrel@dancol.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:234924
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/234924>

> Date: Wed, 3 Apr 2019 09:58:35 -0700
> From: "Daniel Colascione" <dancol@dancol.org>
> Cc: "Daniel Colascione" <dancol@dancol.org>,
>  emacs-devel@gnu.org
> 
> >> We "support" dumping only from dedicated batch instances in that for now
> >> we should consider only bugs in that use case release-blocking, but I
> >> don't want to gratuitously break other use cases like dumping
> >> interactive
> >> sessions without killing them, since these use cases are meant to work
> >> and
> >> we'll give them the same level of support someday soon.
> >
> > OK, but is there any reason dump_unwind_cleanup doesn't restore
> > post-gc-hook?  Omission?
> 
> Not restoring post-gc-hook is a bug. Thanks for spotting that!

Thanks, I fixed both issues.