From: Eli Zaretskii <eliz@gnu.org>
To: "Daniel Colascione" <dancol@dancol.org>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 1072155: Avoid duplicate entries in process-environment after re-dumping
Date: Wed, 03 Apr 2019 20:32:26 +0300 [thread overview]
Message-ID: <831s2jdmfp.fsf@gnu.org> (raw)
In-Reply-To: <2f59c1ff3d4ad006c09634813e6724b8.squirrel@dancol.org>
> Date: Wed, 3 Apr 2019 09:58:35 -0700
> From: "Daniel Colascione" <dancol@dancol.org>
> Cc: "Daniel Colascione" <dancol@dancol.org>,
> emacs-devel@gnu.org
>
> >> We "support" dumping only from dedicated batch instances in that for now
> >> we should consider only bugs in that use case release-blocking, but I
> >> don't want to gratuitously break other use cases like dumping
> >> interactive
> >> sessions without killing them, since these use cases are meant to work
> >> and
> >> we'll give them the same level of support someday soon.
> >
> > OK, but is there any reason dump_unwind_cleanup doesn't restore
> > post-gc-hook? Omission?
>
> Not restoring post-gc-hook is a bug. Thanks for spotting that!
Thanks, I fixed both issues.
prev parent reply other threads:[~2019-04-03 17:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190321155613.6127.22574@vcs0.savannah.gnu.org>
[not found] ` <20190321155614.E6343209B2@vcs0.savannah.gnu.org>
2019-04-02 19:02 ` [Emacs-diffs] master 1072155: Avoid duplicate entries in process-environment after re-dumping Daniel Colascione
2019-04-02 19:24 ` Eli Zaretskii
2019-04-02 20:11 ` Daniel Colascione
2019-04-03 9:22 ` Eli Zaretskii
2019-04-03 16:58 ` Daniel Colascione
2019-04-03 17:32 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831s2jdmfp.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=dancol@dancol.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).