From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Towards a cleaner build Date: Fri, 17 May 2019 08:50:26 +0300 Message-ID: <831s0xd3z1.fsf@gnu.org> References: Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="51136"; mail-complaints-to="usenet@blaine.gmane.org" Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 17 07:51:23 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hRVm6-000D7H-ML for ged-emacs-devel@m.gmane.org; Fri, 17 May 2019 07:51:22 +0200 Original-Received: from localhost ([127.0.0.1]:42796 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRVm5-0007zV-GY for ged-emacs-devel@m.gmane.org; Fri, 17 May 2019 01:51:21 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38237) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRVlL-0007zB-Kh for emacs-devel@gnu.org; Fri, 17 May 2019 01:50:36 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36595) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRVlL-0002D9-6F; Fri, 17 May 2019 01:50:35 -0400 Original-Received: from [176.228.60.248] (port=2115 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hRVlK-00074M-Li; Fri, 17 May 2019 01:50:35 -0400 In-reply-to: (message from Lars Ingebrigtsen on Fri, 17 May 2019 06:29:51 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236625 Archived-At: > From: Lars Ingebrigtsen > Date: Fri, 17 May 2019 06:29:51 +0200 > Cc: emacs-devel@gnu.org > > > (defun display-completion-list (completions &optional common-substring) > > [...] > > (declare (advertised-calling-convention (completions) "24.4")) > > Oh, I see. So should we just remove the optional argument now -- 24.4 > was in... 2011? I'd prefer if we made the byte-compiler warnings smarter in this case. It shouldn't behave like we are shooting ourselves in the foot in these cases. Do we have a means to tell the byte-compiler "don't emit this specific warning for that function"? If not, perhaps we should.