From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Towards a cleaner build: disass.el
Date: Thu, 13 Jun 2019 06:43:32 +0300
Message-ID: <831rzy880r.fsf@gnu.org>
References: <m3r28xrfl9.fsf@gnus.org> <m3ef4iq0pd.fsf@gnus.org>
 <CAM-tV--Rvb0RFRfpP4u348U0-EAcN-NLVfEzTRkE9Rc7RAacWg@mail.gmail.com>
 <m38suqq03h.fsf@gnus.org> <83zhn6zkgf.fsf@gnu.org>
 <m3lfyqobq7.fsf@gnus.org>
 <CAM-tV--MF1oCYQ+BFX=PW27ZMYEPzxajkGb0oo7msVidHD-Ceg@mail.gmail.com>
 <m3d0k1o6gl.fsf@gnus.org> <jwvimtttg8t.fsf-monnier+emacs@gnu.org>
 <m3ftoi3m5o.fsf@gnus.org> <m3blz63j41.fsf@gnus.org>
 <CAM-tV-85nAR_vHoXhmZfuu1ndfK-6FVopzKMbwtfDmm7gkU7Kw@mail.gmail.com>
 <m336ki3ghd.fsf@gnus.org> <jwvimteipi7.fsf-monnier+emacs@gnu.org>
 <m3v9xezi75.fsf@gnus.org> <m3r282zfjx.fsf@gnus.org>
 <83a7eo9nsh.fsf@gnu.org> <m3k1dqzyul.fsf@gnus.org>
 <m3a7emmltr.fsf_-_@gnus.org> <m35zpaml7e.fsf_-_@gnus.org>
 <m3wohql5ag.fsf_-_@gnus.org> <m3h88ul47f.fsf_-_@gnus.org>
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="205152"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: emacs-devel@gnu.org
To: Lars Ingebrigtsen <larsi@gnus.org>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jun 13 05:43:49 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hbGeT-000rHf-5o
	for ged-emacs-devel@m.gmane.org; Thu, 13 Jun 2019 05:43:49 +0200
Original-Received: from localhost ([::1]:36770 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.86_2)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hbGeS-00079Y-6x
	for ged-emacs-devel@m.gmane.org; Wed, 12 Jun 2019 23:43:48 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58196)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <eliz@gnu.org>) id 1hbGeD-00078B-T1
 for emacs-devel@gnu.org; Wed, 12 Jun 2019 23:43:35 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:52295)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
 id 1hbGeC-0008F9-MM; Wed, 12 Jun 2019 23:43:33 -0400
Original-Received: from [176.228.60.248] (port=4688 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1hbGeC-0006RZ-1q; Wed, 12 Jun 2019 23:43:32 -0400
In-reply-to: <m3h88ul47f.fsf_-_@gnus.org> (message from Lars Ingebrigtsen on
 Thu, 13 Jun 2019 02:27:32 +0200)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:237481
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/237481>

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Thu, 13 Jun 2019 02:27:32 +0200
> 
>     (if (consp obj)
> 	(setq bytes (car (cdr obj))		;the byte code
> 	      constvec (car (cdr (cdr obj))))	;constant vector
>       ;; If it is lazy-loaded, load it now
>       (fetch-bytecode obj)
>       (setq bytes (aref obj 1)
> 	    constvec (aref obj 2)))
>     (let ((lap (byte-decompile-bytecode (string-as-unibyte bytes) constvec))
> 
> 
> But...
> 
> (multibyte-string-p (aref (byte-compile '(lambda (foo) (+ 4 foo))) 1))
> => nil
> 
> Is there any way the byte string in a byte-compiled function is
> multibyte?  It kinda looks like a NOP to me...

I suggest to remove the call and add an assertion there.  This way, we
will soon know if its a NOP or not.

Thanks.