From: Eli Zaretskii <eliz@gnu.org>
To: Ergus <spacibba@aol.com>
Cc: emacs-devel@gnu.org, ingo.lohmar@posteo.net
Subject: Re: :extend t inheritance
Date: Sun, 27 Oct 2019 07:51:07 +0200 [thread overview]
Message-ID: <831ruyu46s.fsf@gnu.org> (raw)
In-Reply-To: <453335474.949467.1572131620451@mail.yahoo.com> (message from Ergus on Sat, 26 Oct 2019 23:13:40 +0000 (UTC))
> Date: Sat, 26 Oct 2019 23:13:40 +0000 (UTC)
> From: Ergus <spacibba@aol.com>
> Cc: ingo.lohmar@posteo.net, emacs-devel@gnu.org
>
> Ohh right, that's the other commit. When fixing this issue I found another error I didn't see in tui. After EOL we
> need to fill with the merged filtered face. To do that we need to add a stretch glyph; but we were just adding a
> normal glyph with a ' ' so the face was not really extended, just the background color because the X display
> engine always do that. But, for example, underline was not extended. This commit fixes just that.
> stretch_ascent was moved out of the if(column_indicator) because the new stretch_glyphs needs it any way
> and the two comments were 1) for old moved code not there anymore and 2) to describe the situation of the
> glyphs color extension (mention in previous paragraph) that we don't need to work around anymore because
> the glyph fills the entire screen now..
I'm still a bit confused: was the problem you found happening in GUI
frames or in text-mode frames? You say "tui", but then talk about
something X does...
next prev parent reply other threads:[~2019-10-27 5:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 20:34 :extend t inheritance Ingo Lohmar
2019-10-24 13:46 ` Eli Zaretskii
2019-10-24 15:38 ` Kévin Le Gouguec
2019-10-24 17:39 ` Ingo Lohmar
2019-10-24 22:22 ` Ergus
2019-10-26 1:49 ` Ergus
2019-10-26 7:28 ` Eli Zaretskii
2019-10-26 19:21 ` Ergus
2019-10-26 19:45 ` Eli Zaretskii
2019-10-26 23:13 ` Ergus
2019-10-27 5:51 ` Eli Zaretskii [this message]
2019-10-27 11:01 ` Ergus
2019-10-29 14:27 ` Eli Zaretskii
2019-10-28 21:24 ` Ergus
2019-10-29 3:28 ` Eli Zaretskii
2019-10-26 8:55 ` Ingo Lohmar
2019-10-26 11:41 ` Ergus
2019-10-26 11:49 ` Ingo Lohmar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831ruyu46s.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=ingo.lohmar@posteo.net \
--cc=spacibba@aol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).