From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: master 094eb04: Fix MS-Windows build with mingw.org's MinGW
Date: Tue, 26 Nov 2019 20:50:48 +0200
Message-ID: <831rtusc8n.fsf@gnu.org>
References: <20191126171403.25928.6996@vcs0.savannah.gnu.org>
 <20191126171404.9DBBC20B21@vcs0.savannah.gnu.org>
 <m2v9r6jxzh.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="122644"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: emacs-devel@gnu.org
To: Robert Pluim <rpluim@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 26 19:50:51 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1iZfvG-000VmW-Ps
	for ged-emacs-devel@m.gmane.org; Tue, 26 Nov 2019 19:50:50 +0100
Original-Received: from localhost ([::1]:58058 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1iZfvF-0002z5-8S
	for ged-emacs-devel@m.gmane.org; Tue, 26 Nov 2019 13:50:49 -0500
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58167)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>) id 1iZfv8-0002yy-S6
 for emacs-devel@gnu.org; Tue, 26 Nov 2019 13:50:43 -0500
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34249)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
 id 1iZfv8-0006wc-OI; Tue, 26 Nov 2019 13:50:42 -0500
Original-Received: from [176.228.60.248] (port=4431 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1iZfv7-0000QI-Rh; Tue, 26 Nov 2019 13:50:42 -0500
In-reply-to: <m2v9r6jxzh.fsf@gmail.com> (message from Robert Pluim on Tue, 26
 Nov 2019 19:25:54 +0100)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:242743
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/242743>

> From: Robert Pluim <rpluim@gmail.com>
> Cc: Eli Zaretskii <eliz@gnu.org>
> Date: Tue, 26 Nov 2019 19:25:54 +0100
> 
> Thanks for that Eli. Since this is expected to work on pre-Vista
> versions of Windows, is the equivalent to the following hack needed in
> the new network-interface-list:
> 
> 	    case MIB_IF_TYPE_ETHERNET:
> 	      /* Windows before Vista reports wireless adapters as
> 		 Ethernet.  Work around by looking at the Description
> 		 string.  */
> 	      if (strstr (adapter->Description, "Wireless "))
> 		{
> 		  ifmt_idx = WLAN;
> 		  if_num = wlan_count++;
> 		}
> 	      else
> 		{
> 		  ifmt_idx = ETHERNET;
> 		  if_num = eth_count++;
> 		}

I guess so.

> GetAdaptersAddresses returns wchar_t* for the description field, which
> means (I hope), that thereʼs some api for converting it appropriately.

We can use wcsstr instead.