From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master a08320f: * lisp/disp-table.el (make-glyph-code): Remove obsolete comment. Date: Mon, 09 Nov 2020 21:38:37 +0200 Message-ID: <831rh248xu.fsf@gnu.org> References: <20201109171613.6680.13417@vcs0.savannah.gnu.org> <20201109171614.766A220A27@vcs0.savannah.gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6693"; mail-complaints-to="usenet@ciao.gmane.io" Cc: phst@google.com, emacs-devel@gnu.org To: p.stephani2@gmail.com (Philipp Stephani) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Nov 09 20:39:21 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kcD0a-0001cl-UD for ged-emacs-devel@m.gmane-mx.org; Mon, 09 Nov 2020 20:39:20 +0100 Original-Received: from localhost ([::1]:38742 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kcD0a-0001ir-10 for ged-emacs-devel@m.gmane-mx.org; Mon, 09 Nov 2020 14:39:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38872) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcCzo-0001J5-Tw for emacs-devel@gnu.org; Mon, 09 Nov 2020 14:38:32 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49699) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kcCzo-0000vd-HB; Mon, 09 Nov 2020 14:38:32 -0500 Original-Received: from [176.228.60.248] (port=2621 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kcCzn-00018X-PU; Mon, 09 Nov 2020 14:38:32 -0500 In-Reply-To: <20201109171614.766A220A27@vcs0.savannah.gnu.org> (p.stephani2@gmail.com) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258953 Archived-At: > Auto-Submitted: auto-generated > Date: Mon, 9 Nov 2020 12:16:14 -0500 (EST) > From: p.stephani2@gmail.com (Philipp Stephani) > > branch: master > commit a08320f7234685cd84a18040556fd3f7eaacaf45 > Author: Philipp Stephani > Commit: Philipp Stephani > > * lisp/disp-table.el (make-glyph-code): Remove obsolete comment. > --- > lisp/disp-table.el | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/lisp/disp-table.el b/lisp/disp-table.el > index 2e88d35..70343a3 100644 > --- a/lisp/disp-table.el > +++ b/lisp/disp-table.el > @@ -220,8 +220,6 @@ for a graphical frame." > ;;;###autoload > (defun make-glyph-code (char &optional face) > "Return a glyph code representing char CHAR with face FACE." > - ;; Due to limitations on Emacs integer values, faces with > - ;; face id greater than 512 are silently ignored. > (if (not face) > char > (let ((fid (face-id face))) Is this comment really obsolete? We still need to be able to pack a face ID and a 22-bit character codepoint into a single fixnum, which could be a 32-bit data type. See GLYPH_CODE_CHAR, GLYPH_CODE_FACE, and SET_GLYPH_FROM_GLYPH_CODE on dispextern.h.