From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: policy discussion on bundling ELPA packages in the emacs tarball Date: Sat, 23 Jan 2021 10:17:01 +0200 Message-ID: <831rec5apu.fsf@gnu.org> References: <86eeifawx8.fsf@stephe-leake.org> <87czxygdl9.fsf@russet.org.uk> <86tur88izp.fsf@stephe-leake.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37700"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, phillip.lord@russet.org.uk To: Stephen Leake Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 23 09:17:46 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l3E78-0009il-Nd for ged-emacs-devel@m.gmane-mx.org; Sat, 23 Jan 2021 09:17:46 +0100 Original-Received: from localhost ([::1]:35060 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l3E77-0001us-OO for ged-emacs-devel@m.gmane-mx.org; Sat, 23 Jan 2021 03:17:45 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59674) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3E6P-0001TV-1I for emacs-devel@gnu.org; Sat, 23 Jan 2021 03:17:01 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37462) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l3E6N-0003vN-WE; Sat, 23 Jan 2021 03:17:00 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2562 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l3E6N-0006dr-Em; Sat, 23 Jan 2021 03:16:59 -0500 In-Reply-To: <86tur88izp.fsf@stephe-leake.org> (message from Stephen Leake on Fri, 22 Jan 2021 18:50:02 -0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263298 Archived-At: > From: Stephen Leake > Date: Fri, 22 Jan 2021 18:50:02 -0800 > Cc: emacs-devel > > > How does that work with ELPA sub-modules? Git worktrees I think hard > > links, so the files sizes are much smaller, but with submodules I am > > going to get some of ELPA and it's .git multiple times? > > Hmm. Perusing https://git-scm.com/docs/gitsubmodules hints that the > submodules could be worktrees if the "Git directory located under the > $GIT_DIR/modules/" can be a worktree link, but there's no option for > 'git submodule add' to specify that. > > Doing a web search found: > > https://stackoverflow.com/questions/31871888/what-goes-wrong-when-using-git-worktree-with-git-submodules > > which says using worktrees that contain submodules is not a good idea. > > and > https://github.com/git/git/commit/1a248cf21d450eb911d01a89c84412c2da365e66 > > which is 4 years old, but indicates that mixing worktrees and submodules > was an issue then. > > I'll have to test some stuff. My impression is that some of the problems were fixed, but it will be important to know which versions of Git fixed them, so that those who use worktrees could decide whether they need to upgrade. > If the submodules cannot be worktrees, then I think we have to > abandon this approach. I'm not sure. There are alternatives to using worktrees, so the fact that some of us use worktrees in some workflows should not necessarily veto the submodule solution to integrating ELPA into Emacs, because this integration is more important than personal workflows. But maybe I misunderstand what you mean by "submodule cannot be worktrees", because AFAIU Phillip raised an issue that is a different one: whether submodules live well with different branches being checked out in different worktrees -- there's nothing there to suggest that submodules themselves should be worktrees.