unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Anand Tamariya <atamariya@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Basic WYSIWYG printing in GNU Emacs (Arabic & Hebrew)
Date: Wed, 11 Aug 2021 14:37:24 +0300	[thread overview]
Message-ID: <831r70fc0b.fsf@gnu.org> (raw)
In-Reply-To: <CADm7Y4=5GV9ajqUp0LA+p5w2z=o_D9fnbdCmOxoKfsw8tWCepQ@mail.gmail.com> (message from Anand Tamariya on Wed, 11 Aug 2021 09:18:23 +0530)

> From: Anand Tamariya <atamariya@gmail.com>
> Date: Wed, 11 Aug 2021 09:18:23 +0530
> Cc: emacs-devel@gnu.org
> 
>  Does it also start RTL text at the right edge of the paper?  And how
>  does it reorder characters for printing?
> 
>  (Sorry for asking these questions, but I'm still unable to see
>  anything useful on the GitLab URL you show -- when I go there, I see
>  only the navigation tree on the left and an empty pane on the right.)
> 
> The code uses window positioning information for characters from Emacs and then scales the content to fit
> the print width. 

So this needs the buffer text be displayed in some window, before it
could be printed?

> It uses following API to determine BIDI classification and processes accordingly:
> (get-char-code-property (char-after from) 'bidi-class)

Hmm... not sure this is enough, except in the simplest cases.  The
bidi-class of a character is just its basic attribute; application of
the full Unicode Bidirectional Algorithm can and does change the
effective attributes of some characters, before they are displayed.

Is this test performed on each character or only at the beginning of a
visual line?

And I see that if you detect RTL characters, you just reverse the text
you get?  That is also very simplistic and will work correctly only if
the text includes only strong RTL characters, not numbers and no
embedded LTR characters.

Apologies if I didn't understand what the code does correctly; I only
had a cursory glance on it, and there are not so many comments
explaining what it does.

Thanks.



  reply	other threads:[~2021-08-11 11:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-10  5:41 Basic WYSIWYG printing in GNU Emacs (Arabic & Hebrew) Anand Tamariya
2021-08-10 12:01 ` Eli Zaretskii
2021-08-11  3:48   ` Anand Tamariya
2021-08-11 11:37     ` Eli Zaretskii [this message]
2021-08-11 15:59       ` Anand Tamariya
2021-08-11 16:57         ` Eli Zaretskii
2021-08-12  5:24           ` Anand Tamariya
2021-08-12  6:29             ` Eli Zaretskii
2021-08-12  8:51               ` Anand Tamariya
2021-08-12 11:45                 ` Eli Zaretskii
2021-08-13  9:16                   ` Anand Tamariya
2021-08-11 17:53       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=831r70fc0b.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=atamariya@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).