From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Native compiler - passing command line options to C compiler
Date: Tue, 31 Aug 2021 16:01:48 +0300
Message-ID: <831r69u5s3.fsf@gnu.org>
References: <AM9PR09MB49778CFA83AA6697D09ED01B96CA9@AM9PR09MB4977.eurprd09.prod.outlook.com>
 <83bl5fkvky.fsf@gnu.org> <xjfv93n2im6.fsf@ma.sdf.org>
 <83v93njc3x.fsf@gnu.org> <xjfeeab2eil.fsf@ma.sdf.org>
 <AM9PR09MB49770200D6A3F935A7D42A8C96CB9@AM9PR09MB4977.eurprd09.prod.outlook.com>
 <xjfa6kz2b97.fsf@ma.sdf.org> 
 <AM9PR09MB4977B62F0BAA439E3DB6A53B96CC9@AM9PR09MB4977.eurprd09.prod.outlook.com>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="32364"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: emacs-devel@gnu.org, akrl@sdf.org
To: Arthur Miller <arthur.miller@live.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 31 15:18:56 2021
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1mL3fE-0008Bq-7y
	for ged-emacs-devel@m.gmane-mx.org; Tue, 31 Aug 2021 15:18:56 +0200
Original-Received: from localhost ([::1]:59000 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1mL3fD-0001Hc-2q
	for ged-emacs-devel@m.gmane-mx.org; Tue, 31 Aug 2021 09:18:55 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41806)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1mL3Oo-0006kb-VQ
 for emacs-devel@gnu.org; Tue, 31 Aug 2021 09:02:00 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34490)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1mL3On-00066y-8R; Tue, 31 Aug 2021 09:01:58 -0400
Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2843
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1mL3Om-0004dc-QZ; Tue, 31 Aug 2021 09:01:57 -0400
In-Reply-To: <AM9PR09MB4977B62F0BAA439E3DB6A53B96CC9@AM9PR09MB4977.eurprd09.prod.outlook.com>
 (message from Arthur Miller on Tue, 31 Aug 2021 07:36:47 +0200)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:273582
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/273582>

> From: Arthur Miller <arthur.miller@live.com>
> Cc: Eli Zaretskii <eliz@gnu.org>,  emacs-devel@gnu.org
> Date: Tue, 31 Aug 2021 07:36:47 +0200
> 
> Ok, I have made those changes. I have removed double checks from both
> add_driver_options () and  add_compiler_options (). If it is not OK, I can made
> another one and revert back this change in add_driver_options.

I think you should indeed do the latter.

> I forgott to ask, which Changelog are we talking about? Changelo.3 in top Emacs
> dir or some other file?

No file.  We no longer maintain ChangeLog files by hand, we generate
them from Git log.  So you should include in the patch the log message
formatted according to ChangeLog rules, but not a patch to any
specific ChangeLog file.