From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: PR: dired-do-create-files now checks for trailing slashes in the
 target
Date: Tue, 28 Sep 2021 21:42:54 +0300
Message-ID: <831r58k0cx.fsf@gnu.org>
References: <CAE9z9A0iwx7wQhGQZTkX8o7pZExEmx1FUSMVXByUF63KWDABtw@mail.gmail.com>
 <CADwFkmkU0vjeD-L4FNTAAJrT3hpQZwY7UG8ugEk5GL+FVgpTdA@mail.gmail.com>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="6211"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: rudiwillalwaysloveyou@gmail.com, emacs-devel@gnu.org
To: Stefan Kangas <stefankangas@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 28 20:46:07 2021
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1mVI7D-0001MU-GA
	for ged-emacs-devel@m.gmane-mx.org; Tue, 28 Sep 2021 20:46:07 +0200
Original-Received: from localhost ([::1]:44348 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1mVI7C-0003Zh-FN
	for ged-emacs-devel@m.gmane-mx.org; Tue, 28 Sep 2021 14:46:06 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35586)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1mVI4K-0001od-Mk
 for emacs-devel@gnu.org; Tue, 28 Sep 2021 14:43:08 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:54744)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1mVI4K-00032X-Ea; Tue, 28 Sep 2021 14:43:08 -0400
Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1501
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1mVI4I-0004ow-5P; Tue, 28 Sep 2021 14:43:08 -0400
In-Reply-To: <CADwFkmkU0vjeD-L4FNTAAJrT3hpQZwY7UG8ugEk5GL+FVgpTdA@mail.gmail.com>
 (message from Stefan Kangas on Tue, 28 Sep 2021 11:17:32 -0700)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:275723
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/275723>

> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Tue, 28 Sep 2021 11:17:32 -0700
> 
> Rudi C <rudiwillalwaysloveyou@gmail.com> writes:
> 
> > With this patch, we can move directories into new directories if we
> > explicitly end the new name with a trailing slash.
> >
> > So `/new_name` renames `/old_name` to `/new_name`, while `/new_name/`
> > renames `/old_name` to `/new_name/old_name`.
> 
> Isn't that backwards-incompatible?

It may or may not be, but I'd suggest first to have a reproducible
recipe that demonstrates the problem.  Because I don't think I
understand what this is trying to solve.

In any case, testing the last character for a literal slash is not
TRT; we have functions for distinguishing between a file's name as
directory and the directory's file name.