From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] xwidget: Add xwidget-webkit-buffer-name-format (Re:Re: About rename xwidget-webkit-buffer-name-prefix) Date: Wed, 10 Nov 2021 15:54:21 +0200 Message-ID: <831r3o3ylu.fsf@gnu.org> References: <1fb88962.612a.17d04aea638.Coremail.tumashu@163.com> <87tugkcyfj.fsf@yahoo.com> <4e33ab77.4b00.17d08eb9d6c.Coremail.tumashu@163.com> <87k0hg73vb.fsf@yahoo.com> <5a34c1b6.5a6c.17d09403c8c.Coremail.tumashu@163.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3032"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, emacs-devel@gnu.org To: tumashu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 10 14:55:26 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mko4U-0000XG-9S for ged-emacs-devel@m.gmane-mx.org; Wed, 10 Nov 2021 14:55:26 +0100 Original-Received: from localhost ([::1]:52086 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mko4S-0006EV-H9 for ged-emacs-devel@m.gmane-mx.org; Wed, 10 Nov 2021 08:55:24 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:39608) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mko3Y-0004Ej-Qo for emacs-devel@gnu.org; Wed, 10 Nov 2021 08:54:28 -0500 Original-Received: from [2001:470:142:3::e] (port=59490 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mko3X-0006en-10; Wed, 10 Nov 2021 08:54:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Tp8lXGLHigTxt+6YrcZT7kCg4ENuqAqwOD1uOcH/pO8=; b=gTdBLL2f1Jfp plXY0QJSf0eNmiVEpZUwmGu1oywhXfM8CtmszLubi5TjoC/HZv7gS5ZzqT4wdAFfdUPIxC7IfnvhN CzNhHYgEEzmlQrsn80LVml3LW2RFAcyNKfmhNd3esUIxjbcfohjbJjSjohCxT4CLsnd56dfLYdP8w PY5bukDrqTLzAtPvzRcWfWJ30oR8K2av/55s4XYFsxL+X0jOWo3lVC/2Eq7S7XXykPmg+1D/VNBZw Iq9JDNVelL47dePPvkICrjTDwCF4KIBsmV4TkkFUtzpQ01MinzvQ6IaH7LwqMqQixhyVfiMiBan2r GUz8kHhMKLmjAoTctemuhA==; Original-Received: from [87.69.77.57] (port=4637 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mko3W-0003zN-KI; Wed, 10 Nov 2021 08:54:26 -0500 In-Reply-To: <5a34c1b6.5a6c.17d09403c8c.Coremail.tumashu@163.com> (message from tumashu on Wed, 10 Nov 2021 17:49:04 +0800 (CST)) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:279168 Archived-At: > Date: Wed, 10 Nov 2021 17:49:04 +0800 (CST) > From: tumashu > Cc: "emacs-devel@gnu.org" > > -*** New user option 'xwidget-webkit-buffer-name-prefix'. > +*** New user option 'xwidget-webkit-buffer-name-format'. > This allows the user to change the webkit buffer names. Using this option you can control how the xwidget-webkit buffers are named. > +(defcustom xwidget-webkit-buffer-name-format "*xwidget-webkit: %T*" > + "Buffer name format used by `xwidget-webkit' buffers. Template for naming `xwidget-webkit' buffers. It can use the following special constructs: %T -- the title of the Web page loaded by the xwidget. > + (rename-buffer > + (format-spec > + xwidget-webkit-buffer-name-format > + `((?T . ,title))) > + t))))) Hmmm... does this mean that the format spec _must_ contain %T? Because otherwise all the buffers will have the same name, no? Which would mean this change introduces a regression wrt how this worked previously, right?