From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: File names in ChangeLog entries Date: Wed, 01 Dec 2021 05:29:46 +0200 Message-ID: <831r2xt32t.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24509"; mail-complaints-to="usenet@ciao.gmane.io" Cc: stefan@marxist.se, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 01 04:31:21 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1msGL2-0006CS-Ms for ged-emacs-devel@m.gmane-mx.org; Wed, 01 Dec 2021 04:31:20 +0100 Original-Received: from localhost ([::1]:54872 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1msGL0-00065X-RV for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Nov 2021 22:31:18 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:53284) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1msGJj-0004Xo-99 for emacs-devel@gnu.org; Tue, 30 Nov 2021 22:29:59 -0500 Original-Received: from [2001:470:142:3::e] (port=34326 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1msGJj-0006Wp-0K; Tue, 30 Nov 2021 22:29:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=y2J2q9H2SssHyZnEd9iSF6+9Dyj0KQQgGJJA3GIz6tU=; b=JZPaWXG3QSgo uDz6jjTsv06/5TZgEct/Hw6yyC8Dml0ki874R4ISZpQ2x4MoIHxknJnn3+5bC6djTdKQ7nWfIPNpL h3lDg9Qbb81Tqe6MZZzix00pxdjFo3a9u0PBKr3tq7gytE3RyBSn/H9vk/5BK9buh4YjD2qfadZU4 p/spaMKARzBGdYwmFaxjqTmDldNsJ2Cz7bISdkt4uORZVqq7naiUePWabNydpKx5aN2YKSsRX/6fa 5HSYVW154UqebjK5w4sboeG6QNtnpHJeeRGsgAi//0WIcgxaUSV4DL8AlvsJvTW40bC8CxkQylQ/f ziGRi7wP2ePzOS/OwtrEAg==; Original-Received: from [87.69.77.57] (port=2005 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1msGJi-00082d-K0; Tue, 30 Nov 2021 22:29:58 -0500 In-Reply-To: (message from Stefan Monnier on Tue, 30 Nov 2021 18:16:36 -0500) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:280574 Archived-At: > From: Stefan Monnier > Cc: emacs-devel@gnu.org > Date: Tue, 30 Nov 2021 18:16:36 -0500 > > OTOH, I would really appreciate if people could be careful to always > include some kind of file information on the first line of their commit. > Too often I see commits whose first line doesn't unambiguously indicate > which part of Emacs's code is changed. Please also make a point of following the conventions of ChangeLog entries. You (Stefan) are one of the "worst offenders" in that department: your entries look very frequently backwards: first the file and function, then an empty line, then the detailed explanation of the change. It should be the other way around (if you care about the quality of the logs).