From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: Re: master b1e9151: Enable the native display of BMP images on Haiku
Date: Sat, 26 Mar 2022 16:58:22 +0300 [thread overview]
Message-ID: <831qyobytd.fsf@gnu.org> (raw)
In-Reply-To: <875yo04ygp.fsf@yahoo.com> (message from Po Lu on Sat, 26 Mar 2022 21:47:50 +0800)
> From: Po Lu <luangruo@yahoo.com>
> Cc: emacs-devel@gnu.org
> Date: Sat, 26 Mar 2022 21:47:50 +0800
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> From: Po Lu <luangruo@yahoo.com>
> >> Cc: emacs-devel@gnu.org
> >> Date: Sat, 26 Mar 2022 21:22:41 +0800
> >>
> >> Eli Zaretskii <eliz@gnu.org> writes:
> >>
> >> > It's better not, I think. We don't do that elsewhere, do we?
> >>
> >> I think there are a few cases, though probably not deliberate. If you
> >> insist on removing the definition in haikuimage.c, I don't see why not.
> >
> > What are the arguments for leaving it in haikuimage.c?
>
> Mainly so that if the DEFSYM in image.c is moved under some different
> conditionals (or removed entirely), haikuimage.c will continue to work.
Then I don't think we should keep it in haikuimage.c. If it is ever
removed, haikuimage.c will fail to compile, and the error message will
tell exactly what's wrong. We have similar issues with symbols used
in w32font.c that are declared elsewhere, for example. Why would
haikuimage.c be treated differently?
next prev parent reply other threads:[~2022-03-26 13:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-26 12:29 master b1e9151: Enable the native display of BMP images on Haiku Eli Zaretskii
2022-03-26 12:33 ` Po Lu
2022-03-26 13:18 ` Eli Zaretskii
2022-03-26 13:22 ` Po Lu
2022-03-26 13:29 ` Eli Zaretskii
2022-03-26 13:47 ` Po Lu
2022-03-26 13:58 ` Eli Zaretskii [this message]
2022-03-27 0:33 ` Po Lu
2022-03-26 13:49 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831qyobytd.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).