From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix display-buffer-use-some-window to honor reusable-frames Date: Sat, 18 Feb 2023 19:46:53 +0200 Message-ID: <831qmmzx0y.fsf@gnu.org> References: <30c3d810-ed96-a9bd-c622-1761a138515c@gmx.at> <115a6020-2b86-2653-844e-d19eb03cf62c@gmx.at> <94366f16-89d2-68dc-06cd-0989b9dd2698@gmx.at> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8671"; mail-complaints-to="usenet@ciao.gmane.io" Cc: tgbugs@gmail.com, emacs-devel@gnu.org, larsi@gnus.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Feb 18 18:47:39 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pTRJC-00023w-UF for ged-emacs-devel@m.gmane-mx.org; Sat, 18 Feb 2023 18:47:39 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pTRIT-0004qG-E0; Sat, 18 Feb 2023 12:46:53 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pTRIS-0004q4-AK for emacs-devel@gnu.org; Sat, 18 Feb 2023 12:46:52 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pTRIR-0007uz-Kz; Sat, 18 Feb 2023 12:46:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=EIkqWTVSQ6tsx+jO82Uxmnovt70E8w0OwRnwWY304FY=; b=OE8HPQzATH6C VDOPIszopnaPOtXJLIm1Z9SpGhkgntIS71z0kXrqUvqVLtODrKkoEl+T4UUY1mP4WParNlHwEabbk NU2pYgOHTVVyxZsXtYx0rZYN57eDd+f4EeUQTACEzDo7DZSSehKBWdFafVUsOihUHh4GXNxsn+eYr lMFygQCLdEV7eSzScodK9T7Ck0/lwr8i79lc0oDIpNlM9fm2wZ7GaFWUU3II3wzNWUQZd9STp7fMY +LKevpAl8h69YCoXcIQbz6KVS01QCc8lgAKfRhy+DW9X1XkpzkT6j7UB1XANWKJwLijksMWZMi/xO aAUQpAIk6T2tRFPMICkfDA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pTRIR-0007Sm-1w; Sat, 18 Feb 2023 12:46:51 -0500 In-Reply-To: (message from martin rudalics on Sun, 12 Feb 2023 10:33:11 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303532 Archived-At: > Date: Sun, 12 Feb 2023 10:33:11 +0100 > Cc: Eli Zaretskii , emacs-devel@gnu.org, larsi@gnus.org > From: martin rudalics > > I now tried to document everything I wrote so far. The attached patch > also differs from the preceding ones in the following regards: > > - 'display-buffer-reuse-window' calls 'display-buffer--lru-window' with > suitable arguments. This has the benefit that it honors the new > minimum size entries as well which makes the documentation simpler. > It has the disadvantage that if I didn't guess those arguments > correctly, the default behavior of 'display-buffer-use-some-window' > might change wrt previous versions. > > - 'window-bump-use-time' was rewritten taking into account some of the > issues I mentioned in my last posting. > > - A 'bump-use-time' action alist entry has been added. > > I'm not sure whether these changes should be made on the release branch. > IMO a suitable minimal change for the release branch would be to remove > all references to 'display-buffer-avoid-small-windows' and leave > 'display-buffer-use-least-recent-window' and 'window-bump-use-time' > untouched. The latter are here since Emacs 28, so there's a good excuse > for leaving them alone. > > In either case note that I don't synch with Savannah so someone else > would have to apply these changes. Thanks, I installed all of it on the release branch, after adding the log message.