From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Patch for Emacs 29 Date: Tue, 11 Apr 2023 10:50:52 +0300 Message-ID: <831qkqc0wz.fsf@gnu.org> References: <87edorlzdh.fsf.ref@yahoo.com> <87edorlzdh.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25281"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 11 09:51:12 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pm8mW-0006JX-4D for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Apr 2023 09:51:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pm8ln-0004eF-Bu; Tue, 11 Apr 2023 03:50:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pm8ll-0004e3-8R for emacs-devel@gnu.org; Tue, 11 Apr 2023 03:50:25 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pm8lk-0007gy-Vc; Tue, 11 Apr 2023 03:50:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=VX6SAU9fK/g9JFPYiE09GEm8dUYQJkQG0zNI8wGvT4k=; b=lVfGlIZrjEVg gzAt8MKDX0p/4b/y9Mv8kbcT5MZ3ZwKRG1omDxZn6/tDl0Z7qYgxKXYyvuog+x7l4WsRovL1q6xLm tdJ89llPhmyT4q1X589gdrm+Dtl7q6N7fJilPZEBbb6Xnpzwp3Vg3PdMi/F6PbLejBjBHA/p2dN2B ntkOyS7w0K8eLkTL3Hx8Yl0uIYiC8Xubkx8+u7YelCJhqx3Pef6jda4sFQqvqEa4/0UtYSolYncQA RKQSPSHEWQwCCJ7dNR60ptSQ1TdmXog62dtgsnSGX8uqWzVH5OcACMJ9kccgQDvHw3MzIpw4iSXNL O31OVXE+RSE+6HsPtv0sMg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pm8lf-0003dC-Bp; Tue, 11 Apr 2023 03:50:24 -0400 In-Reply-To: <87edorlzdh.fsf@yahoo.com> (message from Po Lu on Tue, 11 Apr 2023 14:14:02 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305233 Archived-At: > From: Po Lu > Date: Tue, 11 Apr 2023 14:14:02 +0800 > > Recent updates to Haiku are unable to build the Emacs 29 pretest: > cfsetspeed is present in termios.h, but is in /system/lib/libbsd.so (and > not the C library), leading to system headers conflicting with the > gnulib replacements. > > The solution is to link Emacs with libbsd so that the system's version > can be found by gnulib. Is this okay for Emacs 29? Are you absolutely sure this couldn't do any harm when building Emacs on older versions of Haiku? Did you try? If this is harmless on older versions, then okay. Otherwise, you will need an additional check for whether -lbsd is needed. Thanks.