From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Android port Date: Fri, 04 Aug 2023 13:40:48 +0300 Message-ID: <831qgjw0nj.fsf@gnu.org> References: <1428589171.162865.1691134964773@mail1.libero.it> <837cqbw8df.fsf@gnu.org> <87cz039m4v.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24407"; mail-complaints-to="usenet@ciao.gmane.io" Cc: angelo.g0@libero.it, emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Aug 04 12:40:55 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qRsEp-0006Cs-Lw for ged-emacs-devel@m.gmane-mx.org; Fri, 04 Aug 2023 12:40:55 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qRsEY-00017d-Tu; Fri, 04 Aug 2023 06:40:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRsEX-00017R-IT for emacs-devel@gnu.org; Fri, 04 Aug 2023 06:40:37 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRsEW-0005cH-IX; Fri, 04 Aug 2023 06:40:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=G89bJY3JI9/e7phVEf8g2zBhieTf+bEk+sD4M/psEU8=; b=IzUH3cytGD5B Ht/u+FpAAIW/82FR096gRdLgP2Zro2rV6TlEB8nI21inczzQy2VVh8bFM/gmPfzs2OBZ7DyMwcEX+ 3lcv1dfZ5hcEXgHxxYv8h6a84wDypRQl61NF3jmQVbnFTgMoeXcH19MkHY8ZouiFWcH6nVA/WS4+4 S/jp6HAFeqpba+0LFSDrjCkhiyGJuo89KfwQeogxbHoxAxFN4567NmPR+RfOlFcSv2GgYxxgzbMdG 4J0ERxOne69PTvgk0/AYjQvsdwb2dn5uQsT76WzlVoc9VuXUYdTJ5MjjP+LnhqIrtWBcr6WNAd5xd Lol5N/E+Ly7cun7UFWBFsA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRsEW-00070C-1J; Fri, 04 Aug 2023 06:40:36 -0400 In-Reply-To: <87cz039m4v.fsf@yahoo.com> (message from Po Lu on Fri, 04 Aug 2023 17:45:20 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308283 Archived-At: > From: Po Lu > Cc: Angelo Graziosi , emacs-devel@gnu.org > Date: Fri, 04 Aug 2023 17:45:20 +0800 > > Eli Zaretskii writes: > > > Is asprintf used in any code that needs to be run in the MS-Windows > > build of Emacs? If not, then the easiest solution is to disable > > building Gnulib's asprintf via nt/gnulib-cfg.mk. > > No, the Gnulib folks added two new checks to vasnprintf.m4 reflecting > new C2X features, that weren't present the last time I fixed the Windows > build. That doesn't answer my question, AFAICT. In the current master we have no uses of asprintf and vasnprintf, so I asked whether it is needed on the branch, and if so, whether the MS-Windows build uses the code where these two functions are called. The way to override Gnulib tests that conclude that some libc function should be replaced is not to override the feature test (unless that feature is supported, but Gnulib doesn't know about it -- which can only happen if we implement the library function inside Emacs). The way to override those is to exclude the relevant Gnulib modules from the Windows build via nt/gnulib-cfg.mk. If that is not appropriate, i.e. if the Gnulib module _is_ actually required in the MS-Windows build, then this is a Gnulib bug that should be reported to them and fixed by them (but in that case you cannot merge the branch until the Gnulib folks provide the fix).