From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Adding refactoring capabilities to Emacs Date: Fri, 08 Sep 2023 21:57:13 +0300 Message-ID: <831qf8wl12.fsf@gnu.org> References: <83fs4f36wi.fsf@gnu.org> <1b963d24-51b3-8128-ad14-e4af2c9f0c43@gutov.dev> <83ledhxk5c.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20619"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, monnier@iro.umontreal.ca, philipk@posteo.net, emacs-devel@gnu.org To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Sep 08 20:57:45 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qegfp-000577-MK for ged-emacs-devel@m.gmane-mx.org; Fri, 08 Sep 2023 20:57:45 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qegfT-0003Gl-JC; Fri, 08 Sep 2023 14:57:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qegfR-0003GO-UR for emacs-devel@gnu.org; Fri, 08 Sep 2023 14:57:21 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qegfR-0006Of-Ic; Fri, 08 Sep 2023 14:57:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=nWLIHnm0zTLMpsBX7p3BlIyjG3S0xZxHGQqALFDXxgE=; b=ir1lX0agrX0tQ5yxIBNA XD4y/viWSQS2ZnZPMtbxh6i4fhzFx4TMCWfKEtstSfnCJZMWSKNM3YWeIfpy/hgU9Da8eQpm0nFLO y4ZJH/ZUzlZLV+GT4pCALbwg+L1AYUn65ZR++8JY1K7L81MCEGtEW6Eukl9VYLDLyd8GLN8YrfVUu TlQsDR3gf1ISbuJIGg78sNnTBOVG+iybACdK2rOCRqEdT+V3ybEzCWdnbO3KSTFWPQT/yJFuGVz6/ DUeJ78FWGQZGQ1U3+2LVBH+OViXHnOKORFdRGBM98bBv3RJ0JFOk1dvyG4BUYz/aRyZJTdmUMylD0 4IglFHo3EK8yxA==; In-Reply-To: (message from =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= on Fri, 8 Sep 2023 19:35:41 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:310362 Archived-At: > From: João Távora > Date: Fri, 8 Sep 2023 19:35:41 +0100 > Cc: Eli Zaretskii , monnier@iro.umontreal.ca, philipk@posteo.net, > emacs-devel@gnu.org > > On Fri, Sep 8, 2023 at 7:25 PM Dmitry Gutov wrote: > > > That seems to rhyme with my proposal. Except instead of "done editing" > > it will be "done reviewing" (though some rare users might engage in > > editing the diff as well). > > It doesn't rhyme at all, unless you really twist your ears. Actually, yes, it does. Mind you, I didn't say that we should rebind "C-c C-c" in diff-mode, I just explained what we use that key sequence for in Emacs.