From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Make ispell localwords safe local variable Date: Fri, 01 Dec 2023 10:03:04 +0200 Message-ID: <831qc6bb9j.fsf@gnu.org> References: <87zg2s97x0.fsf@breatheoutbreathe.in> <83o7j8a59k.fsf@gnu.org> <87h6ozdalc.fsf@breatheoutbreathe.in> <83jztv89gi.fsf@gnu.org> <83wmxikyuk.fsf@gnu.org> <87wmtyv21h.fsf@breatheoutbreathe.in> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22574"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jporterbugs@gmail.com, emacs-devel@gnu.org To: Joseph Turner Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Dec 01 09:03:50 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r8yV3-0005d9-4M for ged-emacs-devel@m.gmane-mx.org; Fri, 01 Dec 2023 09:03:49 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r8yUR-0003PC-Tn; Fri, 01 Dec 2023 03:03:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r8yUQ-0003P4-8p for emacs-devel@gnu.org; Fri, 01 Dec 2023 03:03:10 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r8yUP-0001sG-Nb; Fri, 01 Dec 2023 03:03:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=dfRCJi4dnZlirs7wVvW+gl2d66Ii0CpnrX5izLMf0v8=; b=nXs1F5QfXCb6 B47hOCEWeY3ewIRiEdaU9TCU3mwtXDu2aVJJUoUYX79BOV8yRGkywvnNxrxoZHgzHFlphwIwF5SUq rMmOJS72SMdnDvQDRAIcJKLjEMYjgek73p0jbOeprZATXeOFJKWDI8IbTkCQw66TwudMHNN73WPAP MuRijZm4XzmPxMvwKsZbC0Iwfh6H9sk/VxsY7rCFrOteG15FV/uvFlzKN+pLb93W/nYwUgIyHUK6A YrrFmeUEHIJ6LZTNWPjxM8xNn0S+XMIP0q8oRl7sPOsvH5q/V0Ihb/yHQ4wQ6CLX1khOzohDTl1cO 3zGtR++a5gKxHUJ+HzDgvQ==; In-Reply-To: <87wmtyv21h.fsf@breatheoutbreathe.in> (message from Joseph Turner on Thu, 30 Nov 2023 22:56:45 -0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:313423 Archived-At: > From: Joseph Turner > Cc: jporterbugs@gmail.com, emacs-devel@gnu.org > Date: Thu, 30 Nov 2023 22:56:45 -0800 > > Eli Zaretskii writes: > > > It sounds like no one sees a problem with this change, so I've now > > installed it on the master branch. > > Would you be willing to merge the same commit on the emacs-29 branch? Sorry, no. There were some questions about this being safe that I think only time can answer in a satisfactory manner. Leaving this on master will give users enough time to try this and provide feedback in case we overlooked something, before we release that code. > If ispell-buffer-session-localwords is not safe, then package-vc-install > fails to install packages which set it in a dir-locals.el. This is > currently the case with hyperdrive.el, whose manual recommends that > users mark it as safe in their own configuration prior to installation. Users who are hit by this problem can indeed add the necessary form in their init files. Or they can use the development version from the master branch. Or install the change locally and rebuild Emacs 29. I'm sorry, but declaring a variable safe is a serious business in Emacs, and we cannot do that in the middle of releasing a version of Emacs which was used and tested without such a declaration.