* fix pop snarfing on Windows Rmail
@ 2008-08-20 22:38 John Paul Wallington
2008-08-21 5:31 ` Eli Zaretskii
0 siblings, 1 reply; 3+ messages in thread
From: John Paul Wallington @ 2008-08-20 22:38 UTC (permalink / raw)
To: emacs-devel
I have a Windows machine where Rmail is configured like this:
(setq rmail-primary-inbox-list '("po:user:localhost"))
(setq rmail-remote-password-required t)
(setq rmail-remote-password "password")
and it didn't work to get any mail from the pop server.
Looks like this patch is needed:
2008-08-20 John Paul Wallington <jpw@pobox.com>
* mail/rmail.el (rmail-insert-inbox-text): Ensure that the
filename of `tofile' doesn't contain any colons on Windows
and Cygwin systems.
Index: rmail.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/mail/rmail.el,v
retrieving revision 1.454
diff -u -r1.454 rmail.el
--- rmail.el 6 May 2008 07:22:26 -0000 1.454
+++ rmail.el 20 Aug 2008 22:22:51 -0000
@@ -1804,8 +1804,8 @@
(concat ".newmail-"
(file-name-nondirectory
(if (memq system-type '(windows-nt cygwin))
- ;; cannot have "po:" in file name
- (substring file 3)
+ ;; cannot have colons in file name
+ (replace-regexp-in-string ":" "-" file)
file)))
;; Use the directory of this rmail file
;; because it's a nuisance to use the homedir
I'll install it in a few days unless someone objects.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: fix pop snarfing on Windows Rmail
2008-08-20 22:38 fix pop snarfing on Windows Rmail John Paul Wallington
@ 2008-08-21 5:31 ` Eli Zaretskii
2008-08-21 12:36 ` John Paul Wallington
0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2008-08-21 5:31 UTC (permalink / raw)
To: John Paul Wallington; +Cc: emacs-devel
> Date: Wed, 20 Aug 2008 23:38:40 +0100
> From: jpw@pobox.com (John Paul Wallington)
>
> Looks like this patch is needed:
>
> 2008-08-20 John Paul Wallington <jpw@pobox.com>
>
> * mail/rmail.el (rmail-insert-inbox-text): Ensure that the
> filename of `tofile' doesn't contain any colons on Windows
> and Cygwin systems.
>
> Index: rmail.el
> ===================================================================
> RCS file: /sources/emacs/emacs/lisp/mail/rmail.el,v
> retrieving revision 1.454
> diff -u -r1.454 rmail.el
> --- rmail.el 6 May 2008 07:22:26 -0000 1.454
> +++ rmail.el 20 Aug 2008 22:22:51 -0000
> @@ -1804,8 +1804,8 @@
> (concat ".newmail-"
> (file-name-nondirectory
> (if (memq system-type '(windows-nt cygwin))
> - ;; cannot have "po:" in file name
> - (substring file 3)
> + ;; cannot have colons in file name
> + (replace-regexp-in-string ":" "-" file)
> file)))
> ;; Use the directory of this rmail file
> ;; because it's a nuisance to use the homedir
>
> I'll install it in a few days unless someone objects.
I agree with the change, but please also add ms-dos to the list of
systems that need this.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: fix pop snarfing on Windows Rmail
2008-08-21 5:31 ` Eli Zaretskii
@ 2008-08-21 12:36 ` John Paul Wallington
0 siblings, 0 replies; 3+ messages in thread
From: John Paul Wallington @ 2008-08-21 12:36 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel
> I agree with the change, but please also add ms-dos to the list of
> systems that need this.
Sure. Installed.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-08-21 12:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-20 22:38 fix pop snarfing on Windows Rmail John Paul Wallington
2008-08-21 5:31 ` Eli Zaretskii
2008-08-21 12:36 ` John Paul Wallington
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).