From: David Reitter <david.reitter@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: Get rid of per-frame settings of faces via Xresources
Date: Mon, 4 May 2009 20:21:03 -0400 [thread overview]
Message-ID: <82DC2034-022F-492B-B0D9-D4D67724B1B2@gmail.com> (raw)
In-Reply-To: <jwv4ow0vcnp.fsf-monnier+emacs-23.2@gnu.org>
Well, the subject line was informative enough.
If I interpret you correctly: We've had (some of) that removed in
Aquamacs (back then based on pre Emacs 22.1 code) simply because frame
creation was slowed down tremendously (seconds!) when many faces were
known to Emacs (as is the case when you use color themes and you try
out a bunch of them during the session). I decided not to support X
resources on the Mac (under Carbon) - I don't think anybody missed
it. ]
I'm not sure about X of course.
*** lisp/faces.el 13 Apr 2007 18:24:53 +0100 1.370
--- lisp/faces.el 13 Jul 2007 18:56:06 +0100
***************
*** 320,326 ****
(defun set-face-attributes-from-resources (face frame)
"Set attributes of FACE from X resources for FRAME."
! (when (memq (framep frame) '(x w32 mac))
(dolist (definition face-x-resources)
(let ((attribute (car definition)))
(dolist (entry (cdr definition))
--- 320,326 ----
(defun set-face-attributes-from-resources (face frame)
"Set attributes of FACE from X resources for FRAME."
! (when (eq (framep frame) 'x)
(dolist (definition face-x-resources)
(let ((attribute (car definition)))
(dolist (entry (cdr definition))
***************
*** 1789,1796 ****
(condition-case ()
(progn
(face-spec-set face (face-user-default-spec face) frame)
! (if (memq window-system '(x w32 mac))
! (make-face-x-resource-internal face frame))
(internal-merge-in-global-face face frame))
(error nil)))
;; Apply the attributes specified by frame parameters. This
--- 1789,1796 ----
(condition-case ()
(progn
(face-spec-set face (face-user-default-spec face) frame)
! (if (eq window-system 'x)
! (make-face-x-resource-internal face frame))
(internal-merge-in-global-face face frame))
(error nil)))
;; Apply the attributes specified by frame parameters. This
next prev parent reply other threads:[~2009-05-05 0:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-04 20:25 Get rid of per-frame settings of faces via Xresources Stefan Monnier
2009-05-05 0:04 ` Samuel Bronson
2009-05-05 3:35 ` Stefan Monnier
2009-05-05 0:21 ` David Reitter [this message]
2009-05-05 1:19 ` Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82DC2034-022F-492B-B0D9-D4D67724B1B2@gmail.com \
--to=david.reitter@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).