From mboxrd@z Thu Jan 1 00:00:00 1970 Path: quimby.gnus.org!not-for-mail From: "Eli Zaretskii" Newsgroups: gmane.emacs.devel Subject: Re: list-colors-display shows only one color Date: Mon, 11 Feb 2002 21:48:25 +0200 Message-ID: <8296-Mon11Feb2002214825+0200-eliz@is.elta.co.il> References: <20020211184827.60D5.LEKTU@terra.es> Reply-To: Eli Zaretskii NNTP-Posting-Host: quimby2.netfonds.no X-Trace: quimby2.netfonds.no 1013457691 25132 195.204.10.66 (11 Feb 2002 20:01:31 GMT) X-Complaints-To: usenet@quimby2.netfonds.no NNTP-Posting-Date: 11 Feb 2002 20:01:31 GMT Cc: emacs-devel@gnu.org Original-Received: from fencepost.gnu.org ([199.232.76.164]) by quimby2.netfonds.no with esmtp (Exim 3.12 #1 (Debian)) id 16aMdm-0006XG-00 for ; Mon, 11 Feb 2002 21:01:30 +0100 Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org) by fencepost.gnu.org with esmtp (Exim 3.33 #1 (Debian)) id 16aMTj-0003k0-00; Mon, 11 Feb 2002 14:51:07 -0500 Original-Received: from thor.inter.net.il ([192.114.186.11]) by fencepost.gnu.org with esmtp (Exim 3.33 #1 (Debian)) id 16aMSX-0003gG-00 for ; Mon, 11 Feb 2002 14:49:53 -0500 Original-Received: from zaretsky (diup-221-105.inter.net.il [213.8.221.105]) by thor.inter.net.il (Mirapoint) with ESMTP id AGG30716; Mon, 11 Feb 2002 21:49:46 +0200 (IST) Original-To: lektu@terra.es X-Mailer: emacs 21.2.50 (via feedmail 8 I) and Blat ver 1.8.9 In-reply-to: <20020211184827.60D5.LEKTU@terra.es> (message from Juanma Barranquero on Mon, 11 Feb 2002 19:12:33 +0100) Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.5 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: quimby.gnus.org gmane.emacs.devel:1009 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:1009 > From: Juanma Barranquero > Date: Mon, 11 Feb 2002 19:12:33 +0100 > > M-x list-colors-display shows only one color ("snow") in my system, a > Windows XP in 32-bit color mode. Previously it showed the full list. > > (x-display-color-cells) returns 1, BTW. That's the bug, right there: x-display-color-cells should report the true number of colors supported by the display. If it reports 1, many features in color support will start to break down, list-colors-display being the least of them. The change I made simply makes a point of not displaying more colors than the terminal supports. That is The Right Thing, IMHO, since otherwise someone could set internal variables and lists of colors to preposterous values, and get strange results in list-colors-display. It is also needed for extended color support on tty's, where the number of colors in tty-color-alist can be much larger than the actual number of distinct colors a tty can display. _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://mail.gnu.org/mailman/listinfo/emacs-devel